This repository was archived by the owner on Aug 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
reviewed
Apr 29, 2020
tomerd
reviewed
Apr 29, 2020
tomerd
reviewed
Apr 29, 2020
tomerd
reviewed
Apr 29, 2020
tomerd
reviewed
Apr 29, 2020
this is great @tanner0101 some notes/ideas about security best practices |
tomerd
reviewed
Jun 26, 2020
tomerd
reviewed
Jun 26, 2020
@tomerd updated. |
tomerd
reviewed
Aug 8, 2020
|
||
You can now start the executable. Supply the desired IP address and port. Binding to port `80` requires sudo, so we use `8080` instead. | ||
|
||
[TODO]: <> (Link to Nginx guide once available for serving on port 80) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't show up in the rendered version: https://github.com/swift-server/guides/blob/tn-digital-ocean/ubuntu.md
It is just there to remind me when adding the Nginx guide. I can remove if needed though.
tomerd
reviewed
Aug 8, 2020
tomerd
reviewed
Aug 8, 2020
tomerd
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two guides:
Future direction