Guide for AWS #45
Guide for AWS #45
Conversation
| ``` | ||
| git clone https://github.com/apple/swift-nio.git | ||
| cd swift-nio | ||
| swift build -v --static-swift-stdlib -c release |
There was a problem hiding this comment.
since swift-nio is a library this may be confusing. either we pick another example, or at least lets change the command and call out explicitly that are we building the example NIOHTTP1Server target which ships with swift-nio to make things clearer to a reader that is not familiar with those details
There was a problem hiding this comment.
I used swift-nio to parallel what was used in the ubuntu guide. I added a line of description (also matching the ubuntu guide) in the latest push
|
|
||
| Finally, check that Swift is correctly installed by running the Swift REPL: `swift`. | ||
|
|
||
|  |
There was a problem hiding this comment.
would it be easier to do the build stage in Docker? instead of downloading and installing the toolchain, one could build in docker on their development machine (or an EC2 instance for development/build/CI purposes), then scp to the runtime EC2 instance.
There was a problem hiding this comment.
🤷♂️ Both seem equally easy/hard to me. If you have a strong preference I can update it.
There was a problem hiding this comment.
dockering it up may be simpler for people to follow 👍
A bit easier to point people at docker images than tell them what specific things to install every time.
There was a problem hiding this comment.
I’d just add another point of view - one might have a working ec2 setup but doesn’t use docker, which would make adding one more technology more complicated (my actual use case :-). That being said, either works of course, but just wanted to point out it adds another dimension of complexity.
There was a problem hiding this comment.
how about we document both? this way folks that are familiar with Docker can go down that path, and others can install the toolchain on the host. hopefully we will have RPMs soon so the latter will be even simpler
There was a problem hiding this comment.
Yeah, I'm happy to do that. Give me a few days to wrap up another task on my plate and I'll get right on it.
There was a problem hiding this comment.
Just added a Docker option - I hope that's helpful
There was a problem hiding this comment.
Thanks a lot, that's great 👍
Co-authored-by: tomer doron <tomer@apple.com>
Co-authored-by: tachyonics <simon@tachyonics.io>
Co-authored-by: George Barnett <gbarnett@apple.com> Co-authored-by: Kaitlin Mahar <kaitlinmahar@gmail.com>
|
thanks @gibbster this is getting close, made some small suggestions. also, looks like there are unrelated changes that ended up as part of this PR and need to be removed? |
Co-authored-by: Konrad `ktoso` Malawski <konrad.malawski@project13.pl>
|
Thanks for the final change and thanks again the entire guide! |
Updated this to use main branch. Replaces #17