Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Add server-side library development section, link to log levels; improve wording #41

Merged
merged 1 commit into from
May 18, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 15, 2021

No description provided.

@ktoso ktoso requested a review from tomerd May 15, 2021 02:52
@ktoso
Copy link
Contributor Author

ktoso commented May 15, 2021

resolves #38

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this really rise to a top level item? maybe we need an "architecture" or "design" top level that has links to guides like lifecycle, logging, metrics, tracing, etc

@kmahar
Copy link
Contributor

kmahar commented May 15, 2021

I like the suggestion to sort the items in the list into categories a little more, especially given that we want to keep building out guides further and expect this list to grow.
we could probably group all the debugging related links under one "debugging" top level bullet?

@ktoso
Copy link
Contributor Author

ktoso commented May 17, 2021

Sounds good, lemme try to do that here

@ktoso ktoso changed the title link to log levels Add server-side library development section, link to log levels; improve wording May 17, 2021
@ktoso ktoso requested a review from a team May 17, 2021 07:47
@ktoso
Copy link
Contributor Author

ktoso commented May 17, 2021

What about this @kmahar @tomerd ?

I also applied some of nice @wsargent's comments from the other thread

Copy link
Contributor

@kmahar kmahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ktoso
Copy link
Contributor Author

ktoso commented May 18, 2021

Thanks!

@ktoso ktoso merged commit b346abb into swift-server:main May 18, 2021
@ktoso ktoso deleted the wip-link-log branch May 18, 2021 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants