Skip to content

call didSendRequest after write future is fullfilled #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2019
Merged

call didSendRequest after write future is fullfilled #65

merged 3 commits into from
Jul 24, 2019

Conversation

artemredkin
Copy link
Collaborator

To address #38

@artemredkin artemredkin added the kind/enhancement Improvements to existing feature. label Jul 8, 2019
@artemredkin artemredkin added this to the 1.0.0 milestone Jul 8, 2019
ianpartridge
ianpartridge reviewed Jul 8, 2019
View reviewed changes
@artemredkin
Copy link
Collaborator Author

ping @weissi @Lukasa, could you guys please take a look?

Lukasa
Lukasa approved these changes Jul 24, 2019
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@artemredkin artemredkin merged commit 53d5bce into master Jul 24, 2019
@artemredkin artemredkin deleted the invoke_did_send_request_after_future_completes branch July 24, 2019 11:53
@artemredkin artemredkin mentioned this pull request Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@ianpartridge ianpartridge ianpartridge approved these changes

@weissi weissi Awaiting requested review from weissi

@tanner0101 tanner0101 Awaiting requested review from tanner0101

Assignees
No one assigned
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@artemredkin @Lukasa @ianpartridge