Skip to content

document public API #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 17, 2019
Merged

document public API #62

merged 13 commits into from
Jul 17, 2019

Conversation

artemredkin
Copy link
Collaborator

No description provided.

weissi
weissi reviewed Jul 7, 2019
View reviewed changes
@artemredkin artemredkin added this to the 1.0.0 milestone Jul 8, 2019
@artemredkin artemredkin added the kind/enhancement Improvements to existing feature. label Jul 8, 2019
ianpartridge
ianpartridge reviewed Jul 8, 2019
View reviewed changes
Copy link
Contributor

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I've put a sprinkling of comment through - I hope they are helpful.

@artemredkin
Copy link
Collaborator Author

@ianpartridge thank you!

glbrntt
glbrntt reviewed Jul 9, 2019
View reviewed changes
Yasumoto
Yasumoto reviewed Jul 9, 2019
View reviewed changes
@artemredkin @Yasumoto
Update Sources/AsyncHTTPClient/HTTPClient.swift
b1703ff 
Co-Authored-By: Joe Smith <yasumoto7@gmail.com>
Yasumoto
Yasumoto reviewed Jul 9, 2019
View reviewed changes
Yasumoto
Yasumoto reviewed Jul 9, 2019
View reviewed changes
Yasumoto
Yasumoto reviewed Jul 9, 2019
View reviewed changes
Yasumoto
Yasumoto reviewed Jul 9, 2019
View reviewed changes
Yasumoto
Yasumoto reviewed Jul 9, 2019
View reviewed changes
@Yasumoto
Copy link
Contributor

Yasumoto commented Jul 9, 2019

Feel free to add/ignore those small tweaks; this looks amazing and is super helpful! 🥇

ianpartridge and others added 2 commits July 9, 2019 21:30
@ianpartridge @Yasumoto
Update Sources/AsyncHTTPClient/HTTPHandler.swift
93aee65 
Co-Authored-By: Joe Smith <yasumoto7@gmail.com>
@ianpartridge @Yasumoto
Apply suggestions from code review
a4eea07 
Co-Authored-By: Joe Smith <yasumoto7@gmail.com>
@ianpartridge
Copy link
Contributor

Thanks @Yasumoto! I committed the obvious fixes :)

weissi
weissi approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good to me

@weissi weissi merged commit 0c617a4 into master Jul 17, 2019
@weissi weissi deleted the documentation branch July 17, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yasumoto Yasumoto Yasumoto left review comments

@ianpartridge ianpartridge ianpartridge left review comments

@glbrntt glbrntt glbrntt left review comments

@weissi weissi weissi approved these changes

@tomerd tomerd Awaiting requested review from tomerd

@tanner0101 tanner0101 Awaiting requested review from tanner0101

Assignees
No one assigned
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@artemredkin @Yasumoto @ianpartridge @weissi @glbrntt