Add testSelfSignedCertificateIsRejectedWithCorrectError
#594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had bug report that an error during TLS handshake does not get correctly reported and instead a deadlineExceeded error is thrown. We have already fixed the issue in #588 and this PR just adds a test to verify the behavior.
Modifications:
testSelfSignedCertificateIsRejectedWithCorrectErrorwhich uses a self signed certificate to fail the TLS handshakeNWTLSError. Previously a TLS error had adescriptionthat looked like this:which contains not enough for further investigation. It now contains the OSStatus code too which can be used to find out what actually went wrong:
NWErrorHandlerfinalXCTAssertEqualTypeAndValue. It had the left hand side type and right hand side swapped.Result
Improved test coverage and better error messages