Make sure that event loop of task is the same as event loop of channel #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #54, currently if using a shared event loop group object to create a
HTTPClient
, theeventLoop
property of theChannel
will most likely not be the same as theeventLoop
property of theTask
. This can lead to a precondition failure, when the task delegate hops to the the task`s event loop.This patch makes sure that both the task and the connection (channel) share the same event loop instance.
It also add a precondition on
Task.setChannel(_:)
to verify that the channel uses the same event loop as the task.The provided test would trigger the
precondition
failure if the event loops would not match.