MockRequestExecutor calls requestHeadSent
#517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-auto-send-head
branch
from
b67d5bc to
b2f8ce1
Compare
dnadoba
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our actual HTTPRequestExecutors send out a HTTPRequest as soon as they see it and they call
willExecuteRequestandrequestHeadSentin very fast succession on the HTTPExecutableRequest. We should have the same behavior in tests.Changes
requestHeadSentfromMockRequestExecutor.runRequestMockRequestExecutorcallrunRequeston it firstResult
Cleaner, more life like tests