cache NIOSSLContext (saves 27k allocs per conn) #362
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the AsyncHTTPClient open source project | ||
| // | ||
| // Copyright (c) 2021 Apple Inc. and the AsyncHTTPClient project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of AsyncHTTPClient project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| struct LRUCache<Key: Equatable, Value> { | ||
| private typealias Generation = UInt64 | ||
| private struct Element { | ||
| var generation: Generation | ||
| var key: Key | ||
| var value: Value | ||
| } | ||
|
|
||
| private let capacity: Int | ||
| private var generation: Generation = 0 | ||
| private var elements: [Element] | ||
|
|
||
| init(capacity: Int = 8) { | ||
weissi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| precondition(capacity > 0, "capacity needs to be > 0") | ||
| self.capacity = capacity | ||
| self.elements = [] | ||
| self.elements.reserveCapacity(capacity) | ||
| } | ||
|
|
||
| private mutating func bumpGenerationAndFindIndex(key: Key) -> Int? { | ||
| self.generation += 1 | ||
Lukasa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| let found = self.elements.firstIndex { element in | ||
| element.key == key | ||
| } | ||
|
|
||
| return found | ||
| } | ||
|
|
||
| mutating func find(key: Key) -> Value? { | ||
| if let found = self.bumpGenerationAndFindIndex(key: key) { | ||
| self.elements[found].generation = self.generation | ||
| return self.elements[found].value | ||
| } else { | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| @discardableResult | ||
| mutating func append(key: Key, value: Value) -> Value { | ||
| let newElement = Element(generation: self.generation, | ||
| key: key, | ||
| value: value) | ||
| if let found = self.bumpGenerationAndFindIndex(key: key) { | ||
| self.elements[found] = newElement | ||
| return value | ||
| } | ||
|
|
||
| if self.elements.count < self.capacity { | ||
| self.elements.append(newElement) | ||
| return value | ||
| } | ||
| assert(self.elements.count == self.capacity) | ||
| assert(self.elements.count > 0) | ||
|
|
||
| let minIndex = self.elements.minIndex { l, r in | ||
| l.generation < r.generation | ||
| }! | ||
|
|
||
| self.elements.swapAt(minIndex, self.elements.endIndex - 1) | ||
| self.elements.removeLast() | ||
| self.elements.append(newElement) | ||
|
|
||
| return value | ||
| } | ||
|
|
||
| mutating func findOrAppend(key: Key, _ valueGenerator: (Key) -> Value) -> Value { | ||
| if let found = self.find(key: key) { | ||
| return found | ||
| } | ||
|
|
||
| return self.append(key: key, value: valueGenerator(key)) | ||
| } | ||
| } | ||
|
|
||
| extension Array { | ||
| func minIndex(by areInIncreasingOrder: (Element, Element) throws -> Bool) rethrows -> Index? { | ||
| guard var minSoFar: (Index, Element) = self.first.map({ (0, $0) }) else { | ||
| return nil | ||
| } | ||
|
|
||
| for indexElement in self.enumerated() { | ||
| if try areInIncreasingOrder(indexElement.1, minSoFar.1) { | ||
| minSoFar = indexElement | ||
| } | ||
weissi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| return minSoFar.0 | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the AsyncHTTPClient open source project | ||
| // | ||
| // Copyright (c) 2021 Apple Inc. and the AsyncHTTPClient project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of AsyncHTTPClient project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import Logging | ||
| import NIO | ||
| import NIOConcurrencyHelpers | ||
| import NIOSSL | ||
|
|
||
| class SSLContextCache { | ||
Lukasa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| private var state = State.activeNoThread | ||
| private let lock = Lock() | ||
| private var sslContextCache = LRUCache<BestEffortHashableTLSConfiguration, NIOSSLContext>() | ||
| private let threadPool = NIOThreadPool(numberOfThreads: 1) | ||
|
|
||
| enum State { | ||
| case activeNoThread | ||
| case active | ||
| case shutDown | ||
weissi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| init() {} | ||
|
|
||
weissi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| func shutdown() { | ||
| self.lock.withLock { () -> Void in | ||
| switch self.state { | ||
| case .activeNoThread: | ||
| self.state = .shutDown | ||
| case .active: | ||
| self.state = .shutDown | ||
| self.threadPool.shutdownGracefully { maybeError in | ||
| precondition(maybeError == nil, "\(maybeError!)") | ||
| } | ||
| case .shutDown: | ||
| preconditionFailure("SSLContextCache shut down twice") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| deinit { | ||
| assert(self.state == .shutDown) | ||
| } | ||
| } | ||
|
|
||
| extension SSLContextCache { | ||
| private struct SSLContextCacheShutdownError: Error {} | ||
|
|
||
| func sslContext(tlsConfiguration: TLSConfiguration, | ||
| eventLoop: EventLoop, | ||
| logger: Logger) -> EventLoopFuture<NIOSSLContext> { | ||
| let earlyExitError: Error? = self.lock.withLock { () -> Error? in | ||
| switch self.state { | ||
| case .activeNoThread: | ||
| self.state = .active | ||
| self.threadPool.start() | ||
| return nil | ||
| case .active: | ||
| return nil | ||
| case .shutDown: | ||
| return SSLContextCacheShutdownError() | ||
| } | ||
| } | ||
|
|
||
| if let error = earlyExitError { | ||
| return eventLoop.makeFailedFuture(error) | ||
| } | ||
|
|
||
| let eqTLSConfiguration = BestEffortHashableTLSConfiguration(wrapping: tlsConfiguration) | ||
| let sslContext = self.lock.withLock { | ||
| self.sslContextCache.find(key: eqTLSConfiguration) | ||
| } | ||
|
|
||
| if let sslContext = sslContext { | ||
| logger.debug("found SSL context in cache", | ||
| metadata: ["ahc-tls-config": "\(tlsConfiguration)"]) | ||
| return eventLoop.makeSucceededFuture(sslContext) | ||
| } | ||
|
|
||
| logger.debug("creating new SSL context", | ||
| metadata: ["ahc-tls-config": "\(tlsConfiguration)"]) | ||
| let newSSLContext = self.threadPool.runIfActive(eventLoop: eventLoop) { | ||
| try NIOSSLContext(configuration: tlsConfiguration) | ||
| } | ||
|
|
||
| newSSLContext.whenSuccess { (newSSLContext: NIOSSLContext) -> Void in | ||
| self.lock.withLock { () -> Void in | ||
| self.sslContextCache.append(key: eqTLSConfiguration, | ||
| value: newSSLContext) | ||
| } | ||
| } | ||
|
|
||
| return newSSLContext | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.