Fixes propagation of errors during TLS handshake #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemredkin
changed the title
Lukasa
reviewed
Nov 11, 2020
artemredkin
force-pushed
the
fix_ssl_handshakre_error_propagation
branch
from
b505fe5 to
f2872ed
Compare
|
Great question, in test we actually produce two errors, first is |
artemredkin
force-pushed
the
fix_ssl_handshakre_error_propagation
branch
from
f2872ed to
a4c7fad
Compare
Motivation: Right now we only handle one type of SSL error: `.handshakeFailed`, but in reality a multitude of errors can happen, for example, remote party might just close connection that will in turn raise `.uncleanShutdown` error, that will be dropped on the floor and users will only get non-descriptive `NoResult` error. Modifications: Handle all types of SSL errors during handshake instead of just one. Adds a test. Result: Closes swift-server#313
artemredkin
force-pushed
the
fix_ssl_handshakre_error_propagation
branch
from
a4c7fad to
0202d0b
Compare
Lukasa
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Right now we only handle one type of SSL error:
.handshakeFailed,but in reality a multitude of errors can happen, for example, remote
party might just close connection that will in turn raise
.uncleanShutdownerror, that will be dropped on the floor andusers will only get non-descriptive
NoResulterror.Modifications:
Handle all types of SSL errors during handshake instead of just one.
Adds a test.
Result:
Closes #313