Remove spaces in range operators #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no strong opinion here |
ktoso
reviewed
Sep 16, 2019
There was a problem hiding this comment.
Funnily enough we had the same discussion recently and arrived at keeping the space...
Argument made by @drexin was that for .min ... .max a space is needed, e.g. Int.random(in: .min ... .max) or similar APIs.
Though the google style guide https://google.github.io/swift/#horizontal-whitespace does indeed claim an exception for the ... operators.
I personally was convinced by the .max argument, but if people want to stick to google rule here let's go with it. 🤔
|
@ktoso Makes sense too, although personally I would prefer parenthesising or disambiguating with |
artemredkin
approved these changes
Sep 17, 2019
|
thanks, @adtrevor ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a question of preference, but it looks like the most commonly used format for ranges in Swift projects is what can be found in the Swift Book where there is no space between the values and range operators, for instance:
case 200..<300:contrary to the currentcase 200 ..< 300.What do you think? 🙂