Skip to content

Remove 2nd instance of HotModuleReplacementPlugin #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2018
Merged

Remove 2nd instance of HotModuleReplacementPlugin #2

merged 1 commit into from
May 1, 2018

Conversation

kaisermann
Copy link
Member

webpack-serve uses webpack-hot-client which already includes the HotModuleReplacementPlugin.

This fixes the stack overflow with webpackHotUpdateCallback.

`webpack-serve` uses `webpack-hot-client` which [already includes the HotModuleReplacementPlugin](https://github.com/webpack-contrib/webpack-hot-client#gotchas). 

This fixes the stack overflow with `webpackHotUpdateCallback`.
@Rich-Harris Rich-Harris merged commit 0f8faf0 into sveltejs:master May 1, 2018
@Rich-Harris
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants