Skip to content

(fix/ast types) fix: Add missing AttachTag in Tag union type inside the AST namespace from "svelte/compiler" #15946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025

Conversation

xeho91
Copy link
Contributor

@xeho91 xeho91 commented May 18, 2025

Resolves #15945

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 18, 2025

🦋 Changeset detected

Latest commit: a6cf944

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15946

@ota-meshi
Copy link
Member

I think the changes in this PR would include the AttachTag type in the types of Fragment.nodes, but that's not correct.

@xeho91
Copy link
Contributor Author

xeho91 commented May 18, 2025

I think the changes in this PR would include the AttachTag type in the types of Fragment.nodes, but that's not correct.

Awesome catch!

I can think of one solution - use Exclude<Tag, AttachNode>. Could it help, or there's something else I am not seeing?

@paoloricciuti paoloricciuti merged commit b2ce3fa into sveltejs:main May 18, 2025
9 checks passed
@paoloricciuti
Copy link
Member

Thanks 🧡

@github-actions github-actions bot mentioned this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttachNode AST node type is not included in the union type Tag from "svelte/compiler"
3 participants