Skip to content

feat: each without as #14396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 2, 2024
Merged

feat: each without as #14396

merged 9 commits into from
Dec 2, 2024

Conversation

dummdidumm
Copy link
Member

closes #8348

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 4260784

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14396-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14396

@dummdidumm dummdidumm marked this pull request as ready for review December 2, 2024 09:25
@Rich-Harris Rich-Harris merged commit a283083 into main Dec 2, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the each-without-as branch December 2, 2024 13:19
@github-actions github-actions bot mentioned this pull request Dec 2, 2024

```svelte
<div class="chess-board">
{#each { length: 8 }, rank}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to search for the meanings of rank and file.

rank iterates over the rows (length: 8 means there are 8 rows).
file iterates over the columns for each row (length: 8 means there are 8 columns).

Instead of chess-specific terminology, why not use more generic names like rowIndex and columnIndex?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because now you know something that you didn't know before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow omitting the as clause in each statement
3 participants