-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: each without as #14396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: each without as #14396
Conversation
🦋 Changeset detectedLatest commit: 4260784 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14396-svelte.vercel.app/ this is an automated message |
|
|
||
```svelte | ||
<div class="chess-board"> | ||
{#each { length: 8 }, rank} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to search for the meanings of rank and file.
rank iterates over the rows (length: 8 means there are 8 rows).
file iterates over the columns for each row (length: 8 means there are 8 columns).
Instead of chess-specific terminology, why not use more generic names like rowIndex
and columnIndex
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because now you know something that you didn't know before
closes #8348
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint