Skip to content

fix: mobile nav links to SvelteKit tutorials #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Conduitry
Copy link
Member

A note on documentation PRs

Fixes #829. Pointing the link to the right place seemed like the correct way to address this, not fixing the redirects.

This solution feels really ugly, but I don't know how else to deal with this. The metadata that's exposed from the pages seems like it would have to change if we don't want to be looking for substrings in slugs like this. I do note that apps/svelte.dev/src/routes/tutorial/[...slug]/content.server.ts is already doing something similar with looking at the slug strings.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

Copy link

vercel bot commented Nov 12, 2024

@Conduitry is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 2:51am

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the "get path from slug" logic is pretty ad hoc right now, this needs an overhaul in the long run, for now let's get that quick fix in

@dummdidumm dummdidumm merged commit 2e91d80 into sveltejs:main Nov 12, 2024
5 checks passed
@Conduitry Conduitry deleted the gh-829 branch November 12, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile menu - tutorial > sveltekit links are broken
2 participants