Skip to content

feat: Download Svelte App with Tailwind CSS and fix app.css bug along side #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wyMinLwin
Copy link

PR for Issue #1227 Tailwind enabled download with app.css bug

Feat: Download Svelte App with Tailwind CSS when enabled.
Bug: Fix along side with removing app.css unwanted codes.

I created another javascript file to get svelte template but with tailwind css config.
And then based on workspace.tailwind it will be conditionally use different templates

Copy link

vercel bot commented Jun 5, 2025

@wyMinLwin is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm
Copy link
Member

Thank you, looks promising! Could you explain why you didn't use sv to also scaffold Tailwind? sv create has a tailwind option, and AFAIK you can use that through the programmatic API aswell.

@wyMinLwin
Copy link
Author

wyMinLwin commented Jun 11, 2025

Thank you, looks promising! Could you explain why you didn't use sv to also scaffold Tailwind? sv create has a tailwind option, and AFAIK you can use that through the programmatic API aswell.

For Tailwind Feature

What I wanted to do there is to follow the pattern of existing codebase which is fetch via the generated json file. Since we have a layer to cache those templates, I assumed it won't big deal to follow codebase.

For CSS Bug

It's just wrong index due to <style id="injected"></style> instead of <style></style>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants