Skip to content

test: add tests for style directive |important modifier #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@

// Add the IDs of extensions you want installed when the container is created.
"extensions": [
"dbaeumer.vscode-eslint"
"dbaeumer.vscode-eslint",
"svelte.svelte-vscode"
],

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "npm install",
"postCreateCommand": "yarn install",

// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
"remoteUser": "node"
Expand Down
2 changes: 1 addition & 1 deletion explorer-v2/src/lib/ESLintPlayground.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
{#each messages as msg, i (`${msg.line}:${msg.column}:${msg.ruleId}@${i}`)}
<li class="message">
[{msg.line}:{msg.column}]:
{msg.message} (<a href={getURL(msg.ruleId)} target="_blank">
{msg.message} (<a href={getURL(msg.ruleId)} target="_blank" rel="noopener noreferrer">
{msg.ruleId}
</a>)
</li>
Expand Down
2 changes: 1 addition & 1 deletion explorer-v2/src/lib/RulesSettings.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
/>
{rule.ruleId}
</label>
<a href={rule.url} target="_blank"
<a href={rule.url} target="_blank" rel="noopener noreferrer"
><svg
xmlns="http://www.w3.org/2000/svg"
aria-hidden="true"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@types/eslint-scope": "^3.7.0",
"@types/eslint-visitor-keys": "^1.0.0",
"@types/mocha": "^10.0.0",
"@types/node": "^16.0.0",
"@types/node": "^18.11.0",
"@types/semver": "^7.3.9",
"@typescript-eslint/eslint-plugin": "^5.4.0",
"@typescript-eslint/parser": "^5.4.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
}
}
},
"modifiers": [],
"range": [
5,
19
Expand Down Expand Up @@ -214,6 +215,7 @@
}
}
},
"modifiers": [],
"range": [
36,
50
Expand Down Expand Up @@ -363,6 +365,7 @@
}
}
},
"modifiers": [],
"range": [
67,
81
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
}
}
},
"modifiers": [],
"range": [
35,
46
Expand Down Expand Up @@ -470,6 +471,7 @@
}
}
},
"modifiers": [],
"range": [
135,
146
Expand Down Expand Up @@ -708,6 +710,7 @@
}
}
},
"modifiers": [],
"range": [
235,
246
Expand Down Expand Up @@ -909,6 +912,7 @@
}
}
},
"modifiers": [],
"range": [
304,
315
Expand Down Expand Up @@ -963,6 +967,7 @@
}
}
},
"modifiers": [],
"range": [
316,
327
Expand Down Expand Up @@ -1036,6 +1041,7 @@
}
}
},
"modifiers": [],
"range": [
336,
358
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<!-- Styles can be marked as important -->
<div style:color|important="red">...</div>
Loading