Skip to content

Fix no-unused-vars for variables assigned to in template but only used in script #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

Conduitry
Copy link
Member

Fixes #64.

It's been a while since I looked at this code though, and I want to let this sit for a bit before merging, so I can be more sure this is how I want to handle this.

@Conduitry
Copy link
Member Author

Hm the test failure is because this lists eslint@>=6.0.0 as a devdep, and ESLint 7 no longer works on Node 8. I'd rather not just drop Node 8 from the support/testing matrix. I guess I'll sit on this decision as well.

@benmccann benmccann mentioned this pull request Jun 20, 2020
@NicoCevallos
Copy link

NicoCevallos commented Jun 20, 2020

@Conduitry check what I did in the file .github/workflows/ci.yml in this PR #62 to remove test over Node 8 and adding version 14

@benmccann
Copy link
Member

benmccann commented Jun 20, 2020

I think @Conduitry knows how to update ci.yml. The question is whether we should:

I'd rather not just drop Node 8 from the support/testing matrix.

@NicoCevallos
Copy link

Sure, I didn't want to offend anybody with my comment...

Another option could be to publish one version to support newer versions of Node and ESLint, and another to continue supporting Node 8 if it's required. In my comment I mentioned what I did to don't break Node 8 tests, but that limits to install only ESLint 6.x.x

@benmccann
Copy link
Member

Node 8 support was dropped in #77, so hopefully the tests should pass if you rebase this

@Conduitry Conduitry merged commit 361c26f into sveltejs:master Dec 14, 2020
@Conduitry Conduitry deleted the gh-64 branch December 14, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable wrongly labeled as unused
3 participants