Fix false positives for files other than *.svelte in svelte/no-unused-svelte-ignore rule
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
changed the title
svelte/no-unused-svelte-ignore rule*.svelte in svelte/no-unused-svelte-ignore rule
JounQin
reviewed
Jul 29, 2022
tests/utils/utils.ts
Outdated
| const parser = | ||
| path.extname(filename) === ".svelte" | ||
| ? require.resolve("svelte-eslint-parser") | ||
| : undefined | ||
| if (config && typeof config === "object") { |
There was a problem hiding this comment.
Is this check necessary? Shouldn't return Object.assign({ parser }, config, { code, filename }) always work?
There was a problem hiding this comment.
Thank you for let me know. I didn't notice it. I fixed it.
JounQin
reviewed
Jul 29, 2022
| @@ -19,6 +19,9 @@ export default createRule("no-unused-svelte-ignore", { | |||
| }, | |||
|
|
|||
| create(context) { | |||
| if (!context.parserServices.isSvelte) { | |||
JounQin
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false positive in the
svelte/no-unused-svelte-ignorerule for JS files.The rule should not check for files other than those parsed by svelte-eslint-parser.
I also changed the test utility so that it can target fixtures other than .svelte.