Skip to content

test: account for js output in test cases #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Mar 28, 2025

Currently, we assume test output will always be a .svelte file. This isn't always true (e.g. for the derived input/output rule).

This changes the util to basically use the extension of the input in the output, and avoids re-computing it by passing it in.

Currently, we assume test output will always be a `.svelte` file. This
isn't always true (e.g. for the derived input/output rule).

This changes the util to basically use the extension of the input in the
output, and avoids re-computing it by passing it in.
Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: 4c6b22d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

Copy link
Contributor

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@1162

Published Instant Preview Packages:

View Commit

@baseballyama baseballyama merged commit b45cfb6 into sveltejs:main Mar 29, 2025
17 checks passed
@43081j 43081j deleted the cleanup-test-util branch March 29, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants