Skip to content

fix: Revert "Merge pull request #1299 from supabase/rc" #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@supabase/auth-js": "2.65.1",
"@supabase/functions-js": "2.4.3",
"@supabase/node-fetch": "2.6.15",
"@supabase/postgrest-js": "1.17.0",
"@supabase/postgrest-js": "1.16.3",
"@supabase/realtime-js": "2.10.7",
"@supabase/storage-js": "2.7.1"
},
Expand Down
4 changes: 1 addition & 3 deletions src/SupabaseClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,7 @@ export default class SupabaseClient<
? Fn['Returns'][number]
: never
: never,
Fn['Returns'],
FnName,
null
Fn['Returns']
> {
return this.rest.rpc(fn, args, options)
}
Expand Down
10 changes: 0 additions & 10 deletions src/lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,26 +80,16 @@ export type SupabaseClientOptions<SchemaName> = {
accessToken?: () => Promise<string>
}

export type GenericRelationship = {
foreignKeyName: string
columns: string[]
isOneToOne?: boolean
referencedRelation: string
referencedColumns: string[]
}

export type GenericTable = {
Row: Record<string, unknown>
Insert: Record<string, unknown>
Update: Record<string, unknown>
Relationships: GenericRelationship[]
}

export type GenericUpdatableView = GenericTable

export type GenericNonUpdatableView = {
Row: Record<string, unknown>
Relationships: GenericRelationship[]
}

export type GenericView = GenericUpdatableView | GenericNonUpdatableView
Expand Down
7 changes: 2 additions & 5 deletions test/index.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const supabase = createClient<Database>(URL, KEY)
if (error) {
throw new Error(error.message)
}
expectType<Database['public']['Tables']['users']['Row']>(message.user)
expectType<Database['public']['Tables']['users']['Row'] | null>(message.user)
}

// one-to-many relationship
Expand All @@ -99,11 +99,8 @@ const supabase = createClient<Database>(URL, KEY)
// referencing missing column
{
type SelectQueryError<Message extends string> = { error: true } & Message

const res = await supabase.from('users').select('username, dat')
expectType<
PostgrestSingleResponse<SelectQueryError<"column 'dat' does not exist on 'users'.">[]>
>(res)
expectType<PostgrestSingleResponse<SelectQueryError<`Referencing missing column \`dat\``>[]>>(res)
}

// one-to-one relationship
Expand Down
Loading