fix(pglt_workspace): lock #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
commented
Feb 21, 2025
Comment on lines
+47
to
+53
| { | ||
| // return early if the connection string is the same | ||
| let inner = self.inner.read().unwrap(); | ||
| if new_conn_str == inner.conn_str { | ||
| return Ok(SchemaCacheHandle::wrap(inner)); | ||
| } | ||
| } |
There was a problem hiding this comment.
we wrap this into its own block so the lock is dropped after
juleswritescode
approved these changes
Feb 21, 2025
Yeah in this case it should actually be sufficient to just call ist once 😂 |
|
Will do it in a follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes our bug from last night. the issue was actually that the entire server went into a lock when loading the
SchemaCachefor auto-completion, because we did not release the read lock oninnerbefore acquiring the write lock. I wonder how we could write a test for these kind of issues 🤔 maybe some kind of simulation e2e test where we actually start the server and start to send some commands and then stop it again.also removed some spammy logs.