Skip to content

test: add support for create table as #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

cvng
Copy link
Contributor

@cvng cvng commented Jan 2, 2024

What kind of change does this PR introduce?

add tests for create table as

What is the current behavior?

parser collects errors after as keyword (see snapshots)

What is the expected behavior?

parser returns without errors

Additional context

same here, reproduction case cc @psteinroe

@cvng cvng force-pushed the feat/create-table-3 branch from fe28b1d to 6f1712a Compare January 2, 2024 22:29
@psteinroe
Copy link
Collaborator

@cvng if you add the remaining types (e.g. double precision) we can merge this. thanks!

@cvng cvng force-pushed the feat/create-table-3 branch from 5d971cb to df3d5ab Compare January 8, 2024 16:36
@cvng
Copy link
Contributor Author

cvng commented Jan 8, 2024

@cvng if you add the remaining types (e.g. double precision) we can merge this. thanks!

added in 7141a1b

@psteinroe psteinroe merged commit 255ffb3 into supabase-community:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants