This repository was archived by the owner on Feb 9, 2023. It is now read-only.
Fix babel config issues #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ybiquitous @jeddy3 folks, maybe you have time to check this PR? It would really helped me out, as stylelint doesn't work in my project ¯\_(ツ)_/¯ |
|
@hudochenkov OK. Honestly, I'm not so familiar with this project, but anyway I try to review it. 👀 |
ybiquitous
reviewed
May 2, 2022
@ybiquitous Me neither :) Thank you for your review! |
ybiquitous
approved these changes
May 2, 2022
|
Is the next version v0.37.3? The current is v0.37.2. |
|
@hudochenkov Do you want to release the next version? |
|
@ybiquitous yes, I'll release it later today. Thank you! |
|
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247 and #250
Issues was in incorrect config object passed to Babel, if there is existing user Babel config with plugins/presets. As @astone123 pointed out.
I've updated Babel to the latest version just in case. It caused adding
indexin JSONs.