Skip to content

Fixed #897 Bumped minimum Python 3.8 version and dependencies #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

seanlaw
Copy link
Contributor

@seanlaw seanlaw commented Aug 7, 2023

Fixes #897

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

  • Fork, clone, and checkout the newest version of the code
  • Create a new branch
  • Make necessary code changes
  • Install black (i.e., python -m pip install black or conda install -c conda-forge black)
  • Install flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
  • Install pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
  • Run black . in the root stumpy directory
  • Run flake8 . in the root stumpy directory
  • Run ./setup.sh && ./test.sh in the root stumpy directory
  • Reference a Github issue (and create one if one doesn't already exist)

@seanlaw seanlaw changed the title #Fixed 897 Bumped minimum Python 3.8 version and dependencies Fixed #897 Bumped minimum Python 3.8 version and dependencies Aug 7, 2023
@seanlaw
Copy link
Contributor Author

seanlaw commented Aug 7, 2023

@NimaSarajpoor Please review at your earliest convenience

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e31ea13) 98.93% compared to head (009374f) 98.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          84       84           
  Lines       14236    14236           
=======================================
  Hits        14084    14084           
  Misses        152      152           
Files Changed Coverage Δ
setup.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NimaSarajpoor
Copy link
Collaborator

@seanlaw
I am not as meticulous as you here :) I checked the changes in this PR and they look good!

@seanlaw
Copy link
Contributor Author

seanlaw commented Aug 10, 2023

@NimaSarajpoor Thanks for reviewing this!

@seanlaw seanlaw merged commit 900b10c into main Aug 10, 2023
@seanlaw seanlaw deleted the bump_python_version_38 branch September 18, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Minimum Python Version to 3.8
2 participants