-
Notifications
You must be signed in to change notification settings - Fork 29
Improve 'listfile' example #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improve 'listfile' example by providing a example for a 'ffconf_custom.h' file.
Thanks @AnHardt anyway is it really needed to add the config file as by default it is the same? |
Copying the right file (ffconf_default_68300.h) to the right place and renaming to the right name (ffconf_custom.h) are the hurdles to take. I thought that's worth an example. For a first time user of STM32SD the effect of 'fs-lock' is surprising. The reason for not opening the file is not available at the STM32SD-libraries level. To get the reason for the error you have to dig into the underlying FatFs-library. Experience with Arduinos SD-library does not help much because almost all other (Arduino) SD-libraries are based on Greimans SdFat-library. The existance of 'ffconf_custom.h' is completely undocumented at STM32SD level. I think, having a example, is a good idea. |
Not completely... https://github.com/stm32duino/STM32SD#fatfs
Maybe it would be possible to have the reason (I did not check) I think it is more confusing to add the configuration file as the major user part will not use it and use it by default. |
Do what you want. A PR is just a suggestion. |
And also to open discussion. 😉 |
Getting the errors from the underlying lib is not that difficult. On top of my previous changes it could look like AnHardt#1 . An other idea to avoid the difficulties with the locks is, to switch them off by default ( |
I agree. Moreover with the previous FatFS version FS_LOCK is set to 0. I will also integrate your work on getErrorState. |
Aligned with previous FatFS version Refers to #32 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Searched "forever" why the 'listfile' example did not list deeper directories.
Here the solution.
Improve 'listfile' example by providing a example for a 'ffconf_custom.h' file.