Skip to content

run_arduino_sh: Add log command, some improvements #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 4, 2020

Conversation

kbumsik
Copy link
Contributor

@kbumsik kbumsik commented Feb 29, 2020

Related: stm32duino/Arduino_Core_STM32#766

I added log command for newly-introduced core_debug logging feature. I also include some improvements of existing commands, as the git commit messages explains.


This change is Reviewable

@fpistm fpistm requested a review from ABOSTM March 2, 2020 07:58
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm
Copy link
Member

fpistm commented Mar 4, 2020

@kbumsik
can it be merged before the PR in the core?
I guess yes but I prefer ask 😉

@kbumsik
Copy link
Contributor Author

kbumsik commented Mar 4, 2020

Yes, it shouldn't break even with the current Arduino Core v1.8 :)

@fpistm
Copy link
Member

fpistm commented Mar 4, 2020

that's what I thought.
Thanks

@fpistm fpistm added the enhancement New feature or request label Mar 4, 2020
@fpistm fpistm added this to the 1.3.3 milestone Mar 4, 2020
@ABOSTM ABOSTM merged commit 4d64679 into stm32duino:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants