Skip to content

Add generic F411Rx variant #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Add generic F411Rx variant #856

merged 2 commits into from
Jan 10, 2020

Conversation

MCUdude
Copy link
Contributor

@MCUdude MCUdude commented Jan 6, 2020

This pinout is more or less identical to the F401Rx pinout, except for more peripherals. It follows the same pin style as the F401Rx variant.

If an external clock/oscillator is not preset, it will automatically use its own internal oscillator.

@fpistm fpistm added the new variant Add support of new bard label Jan 6, 2020
@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 7, 2020

Seems like STm32F411RC isn't supported in the core files. Is this something that can be fixed relatively easily?

Build HY_TinySTM103TB (42/95)... 
  --> Generic_F401RE SUCESS
  --> Generic_F411RC FAILED
In file included from /home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/stm32/stm32_def.h:34,
                 from /home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/stm32/clock.h:43,
                 from /home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/wiring_time.h:23,
                 from /home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/wiring.h:38,
                 from /home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/Arduino.h:32,
                 from /tmp/BuildOutput_2020-01-06_14-46-42/Generic_F411RC/sketch/BareMinimum.ino.cpp:1:
/home/travis/.arduino15/packages/STM32/hardware/stm32/*/system/Drivers/CMSIS/Device/ST/STM32F4xx/Include/stm32f4xx.h:191:3: error: #error "Please select first the target STM32F4xx device used in your application (in stm32f4xx.h file)"
  191 |  #error "Please select first the target STM32F4xx device used in your application (in stm32f4xx.h file)"
      |   ^~~~~
In file included from /home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/board.h:16,
                 from /home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/wiring.h:41,
                 from /home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/Arduino.h:32,
                 from /tmp/BuildOutput_2020-01-06_14-46-42/Generic_F411RC/sketch/BareMinimum.ino.cpp:1:
/home/travis/.arduino15/packages/STM32/hardware/stm32/*/cores/arduino/stm32/rtc.h:94:2: error: #error "Unknown Family - unknown synchronous prescaler"
   94 | #error "Unknown Family - unknown synchronous prescaler"
      |  ^~~~~
exit status 1

@fpistm
Copy link
Member

fpistm commented Jan 7, 2020

Seems like STm32F411RC isn't supported in the core files. Is this something that can be fixed relatively easily?

This simply means you didn't set the correct product_line:

- GenF4.menu.pnum.Generic_F411RC.build.product_line=STM32F411xC
+ GenF4.menu.pnum.Generic_F411RC.build.product_line=STM32F411xE

@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 7, 2020

This simply means you didn't set the correct product_line

I see. A fix is on its way! Otherwise, does it look OK?

@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 7, 2020

Should be OK now. Now everything is only one commit too.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added this to the 1.8.1 milestone Jan 7, 2020
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 astyle issue to fix.

 This pinout is more or less identical to the F401Rx pinout, except for more peripherals. It follows the same pinstyle as F401Rx.
@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 7, 2020

I'm sorry, should be fixed now.

 Some peripherals were misplaced
@fpistm
Copy link
Member

fpistm commented Jan 7, 2020

I saw you last change, I do not check those comments, the reference is the PeripheralPins.c file which reference all the possible value, that's why it is important to have it up to date and for the dedicated MCU version.

@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 7, 2020

I was looking through some source files for the STM32F411Rx series when I discovered that I had done a mistake when creating the table in variant.h. The contents of PeripheralPins.c is OK. I just find it annoying when comments like this don't match the actual source.

I went through and compared everything in variant.h and PeripheralPins.c to make sure there are no other mistakes. I don't think there are.

@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 10, 2020

I see this is left open. Anything else that should be changed/fixed?

@fpistm fpistm merged commit 548444a into stm32duino:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants