-
Notifications
You must be signed in to change notification settings - Fork 1k
Add generic F411Rx variant #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems like STm32F411RC isn't supported in the core files. Is this something that can be fixed relatively easily?
|
This simply means you didn't set the correct - GenF4.menu.pnum.Generic_F411RC.build.product_line=STM32F411xC
+ GenF4.menu.pnum.Generic_F411RC.build.product_line=STM32F411xE |
I see. A fix is on its way! Otherwise, does it look OK? |
Should be OK now. Now everything is only one commit too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 astyle issue to fix.
This pinout is more or less identical to the F401Rx pinout, except for more peripherals. It follows the same pinstyle as F401Rx.
I'm sorry, should be fixed now. |
Some peripherals were misplaced
I saw you last change, I do not check those comments, the reference is the PeripheralPins.c file which reference all the possible value, that's why it is important to have it up to date and for the dedicated MCU version. |
I was looking through some source files for the STM32F411Rx series when I discovered that I had done a mistake when creating the table in variant.h. The contents of PeripheralPins.c is OK. I just find it annoying when comments like this don't match the actual source. I went through and compared everything in variant.h and PeripheralPins.c to make sure there are no other mistakes. I don't think there are. |
I see this is left open. Anything else that should be changed/fixed? |
This pinout is more or less identical to the F401Rx pinout, except for more peripherals. It follows the same pin style as the F401Rx variant.
If an external clock/oscillator is not preset, it will automatically use its own internal oscillator.