Skip to content

Do not provide some default macro's #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Dec 17, 2018

Include utils.h manually will provide them
Note: str() and xstr() are now capitalized.

Fix #389

@matthijskooijman : any comment are welcome ;)

Include utils.h manually will provide them
Note: str() and xstr() are now capitalized.


Fix stm32duino#389

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
@fpistm fpistm added the fix 🩹 Bug fix label Dec 17, 2018
@fpistm fpistm added this to the 1.5.0 milestone Dec 17, 2018
@fpistm fpistm self-assigned this Dec 17, 2018
Copy link
Contributor

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

One question: Are all users of CONCATS already including utils.h directly? Or should some includes be added there?

@fpistm
Copy link
Member Author

fpistm commented Dec 17, 2018

Luckily utils.h was already included in c files (mainly usbd_desc.c).

@matthijskooijman
Copy link
Contributor

Great!

@fpistm fpistm merged commit e832139 into stm32duino:master Dec 17, 2018
@fpistm fpistm deleted the 389_utils branch December 17, 2018 13:05
benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull request Apr 10, 2019
Do not provide some default macro's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants