Fixe adc #154
Merged
Fixe adc #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dhl <damien.helis@wi6labs.com>
ghost
requested review from
fpistm
requested changes
Nov 21, 2017
variants/NUCLEO_F303RE/variant.cpp
Outdated
| @@ -87,6 +87,8 @@ const PinName digitalPin[] = { | |||
| PC_2, //D54/A8 = D28 | |||
| PC_3, //D55/A9 = D29 | |||
| PC_5, //D56/A10 = D35 | |||
| PB_11, //D57/A11 = D39 | |||
| PB_2, //D58/A12 = D40 | |||
| PC_4 //D57/A11 = D45 | |||
There was a problem hiding this comment.
Please, update comment:
PC_4 //D59/A13 = D45
Signed-off-by: dhl <damien.helis@wi6labs.com>
fpistm
requested changes
Nov 21, 2017
cores/arduino/stm32/analog.c
Outdated
| @@ -614,7 +614,7 @@ uint16_t adc_read_value(PinName pin) | |||
| return 0; | |||
| } | |||
|
|
|||
| #if defined (STM32F0xx) || defined (STM32F1xx) || defined (STM32F3xx) || defined (STM32L4xx) | |||
| #if defined (STM32F0xx) || defined (STM32F1xx) || defined (STM32F3xx) || defined (STM32L4xx) || defined (STM32L0xx) | |||
There was a problem hiding this comment.
please invert L4 and L0 to be aligned with other #if test.
Alphabetical and numbering order.
F0/1/2/3/4/7- L0/1/4
Signed-off-by: dhl <damien.helis@wi6labs.com>
fpistm
approved these changes
Nov 21, 2017
benwaffle
pushed a commit
to benwaffle/Arduino_Core_STM32
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ADC for board F103RB and F303RE.