Patch sm squashed #1526
Closed
Patch sm squashed #1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork to be in line with stm32duino main
Create new variant files Ive mostly filled out the .h and .cpp files Still need to update some of the defines The .ld file is copied verbatim from the seed The .c file still needs to be modified Continue fiddling with pins Simplify to more generic variant Reorder Analog defines (A0, A1, ...) Update analog pin comments Add CV output pins Run AStyle on Patch SM variant files Run AStyle with custom options file remove duplicate linker file Simply use the name in boards.txt Signed-off-by: Frederic Pillon <frederic.pillon@st.com> Clean up useless code, typo and Ax naming in comments Signed-off-by: Frederic Pillon <frederic.pillon@st.com> Fix NUM_ANALOG_INPUTS Comment useless ADC pins As those pins are not defined in the analog array, this save space. Signed-off-by: Frederic Pillon <frederic.pillon@st.com> Correct SPI pin defines Correct I2C pin defines Remove unused pins refactor(scripts): common python functions moved as a module Signed-off-by: Frederic Pillon <frederic.pillon@st.com> refactor(arduino_cli): update to use pathlib Signed-off-by: Frederic Pillon <frederic.pillon@st.com> refactor(scripts): use f-string to ease readability Signed-off-by: Frederic Pillon <frederic.pillon@st.com> fix(arduino_cli): missing failed board count Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): add a dry run option (no build) Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): skip find board when sketch is required Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): avoid search on same base path Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): support version higher or equal to 0.19.0 Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): review find board function Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): workaround to follow simlink Due to issue with Path.glob() which does not follow symlink use glob.glob See: https://bugs.python.org/issue33428 Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): manage additional_urls in the config Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): remove useless code Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): remove skipped from the log and stats Only display the number of skipped build. Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): rework build index to ignore skipped Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): replace arduino builder by arduino-cli Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci: remove old travis path config useless since CI moved to GitHub action. Signed-off-by: Frederic Pillon <frederic.pillon@st.com> ci(arduino_cli): ensure configuration exists Signed-off-by: Frederic Pillon <frederic.pillon@st.com> fix: align index after pin removal Signed-off-by: Frederic Pillon <frederic.pillon@st.com> chore: reference Daisy Patch SM in the README.md Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
|
TODO: add product page link to README |
fpistm
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Thanks for the updated PR.
Just a note, no need to create new PR, simply suqah the branch of the activ PR then force a push then the PR will be updated.
This new one requires some clean up:
- Commit message is not correct as all commits messages were kept.
- Squash the Readme.md commit update
- Rebase properly the branch on main to avoid having the merge commit in the PR.
|
Using #1519 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed version of the PR for the Daisy Patch SM.