Skip to content

Fixed included headers #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Fixed included headers #121

merged 1 commit into from
Oct 6, 2017

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Oct 4, 2017

This PR aims at cleaning header file include.
Before some issue/warning was raised depending of which header was included or the order.
Ex: define in the variant.h was defined or not depending of include use.

With this PR, it is now ok.

@fpistm fpistm added the bug 🐛 Something isn't working label Oct 4, 2017
@fpistm fpistm added this to the Next release milestone Oct 4, 2017
@fpistm fpistm self-assigned this Oct 4, 2017
@fpistm fpistm requested review from VVESTM and a user October 4, 2017 07:44
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a risk with the libraries currently available? Should we test them?

@fpistm
Copy link
Member Author

fpistm commented Oct 5, 2017

I've tested some of them without any issue.
I've checked include of the library while they include Arduino.h it is ok.
Still the variant.h which includes the Arduino.h but this is not ok.
variant.h have to be include alone if we needs only specific config.
It will be corrected thanks:
e6f05a4

@ghost
Copy link

ghost commented Oct 6, 2017

I will remove the variant.h if included in the current libraries on development and only use Arduino.h.
This PR is OK for me.

@fpistm fpistm merged commit dd3e773 into stm32duino:master Oct 6, 2017
@fpistm fpistm deleted the Cleaned_include branch October 6, 2017 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant