Use interrupt mode for I2C transfers #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Sep 27, 2017
cores/arduino/stm32/twi.c
Outdated
| status = HAL_I2C_Master_Transmit_IT(&(obj->handle), dev_address, data, size); | ||
|
|
||
| // wait for transfer completion | ||
| while(HAL_I2C_GetState(&(obj->handle)) != HAL_I2C_STATE_READY){}; |
There was a problem hiding this comment.
Either check for a timeout indeed or maybe at least cehck for possible errors
cores/arduino/stm32/twi.c
Outdated
| ret = I2C_OK; | ||
| } | ||
| // wait for transfer completion | ||
| while(HAL_I2C_GetState(&(obj->handle)) != HAL_I2C_STATE_READY){}; |
Switch from polling mode to IT mode for I2C transfers. For example, this is needed if we want to use SPI and I2C in the same time.
|
Adding timeout following @fprwi6labs and @LMESTM remarks. |
LMESTM
approved these changes
Sep 28, 2017
ghost
self-requested a review
ghost
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced an issue while coding a demo for L475 IoT board that use several sensors on i2c2 and BTLE on SPI3. With the actual polling mode for I2C, the transfers can be disturbed by SPI.
Commit message :
Switch from polling mode to IT mode for I2C transfers.
For example, this is needed if we want to use SPI and
I2C in the same time.