Skip to content

Variant - Daisy #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

Conversation

stephenhensley
Copy link

@stephenhensley stephenhensley commented May 11, 2020

Electrosmith Daisy Variant

Summary

Adds the Electrosmith Daisy as a variant

The Daisy is a small form factor, audio-centric SOM embedding an STM32H750

It features a high-quality,stereo audio codec, 64MB of external SDRAM, 8MB of external flash,

Support for the additional memories/audio has not been added yet (audio seems like it should be done in its own library). So, for now the variant has 512kB of internal SRAM, and 128kB of internal flash mapped as the default memories.

InitVariant() needs to be added to initialize the external memories, but all of the external pins, and several of their alternate functions have been tested (SPI, I2C, UART, ADC, DAC, PWM, etc.).

Validation

Still needs CI validation

Code formatting

  • Ensure AStyle check is passed thanks Travis CI (soon)

@fpistm
Copy link
Member

fpistm commented May 12, 2020

Hi @stephenhensley
thanks for the PR.

I would not add a dedicated entry in the boards.txt for Daisy board.
I would prefer add a Generic H7 entry for that.

@stephenhensley
Copy link
Author

Hi @fpistm

glad to contribute!

That makes sense. So "Daisy Seed" would stay as a variant, but would fall into a new "Board" entry called, "Generic STM32H7 series"?

I can fix that up when I correct the style errors a little later today.

@fpistm
Copy link
Member

fpistm commented May 12, 2020

Yes like the other Generic menu entry.

@fpistm fpistm added the new variant Add support of new bard label May 14, 2020
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my PR electro-smith#5

@fpistm fpistm added the waiting feedback Further information is required label May 14, 2020
@fpistm fpistm added this to the 1.9.0 milestone May 14, 2020
@fpistm
Copy link
Member

fpistm commented May 15, 2020

@stephenhensley I'm currently stating to release the core, could you review and merge my PR ?
Else I will not able to merge this one.
Thanks in advance.

@fpistm fpistm added abandoned No more work on this duplicate This issue or pull request already exists and removed waiting feedback Further information is required labels May 15, 2020
@fpistm fpistm removed this from the 1.9.0 milestone May 15, 2020
fpistm added a commit that referenced this pull request May 15, 2020
Add Daisy Seed variant [replace #1063]
@fpistm
Copy link
Member

fpistm commented May 15, 2020

Merged thanks #1070.

@fpistm fpistm closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned No more work on this duplicate This issue or pull request already exists new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants