Make usbd_interface_init() weak so that it can be redefined in sketch or external library

[edogaldo]

Hello @fpistm, as I can understand function usbd_interface_init() is a hook to initiate USB function (HID at the moment) if required, correct?

Arduino_Core_STM32/cores/arduino/main.cpp

Lines 53 to 59 in 4919790

	int main( void )
	{
	initVariant();
	#if defined(USBCON)
	usbd_interface_init();
	#endif

If yes, what about making its definition

Arduino_Core_STM32/cores/arduino/stm32/usb_interface.c

Lines 119 to 131 in 4e1c225

	void usbd_interface_init(void)
	{
	#ifdef USBD_USE_HID_COMPOSITE
	/* Init Device Library */
	USBD_Init(&hUSBD_Device_HID, &HID_Desc, 0);
	/* Add Supported Class */
	USBD_RegisterClass(&hUSBD_Device_HID, USBD_COMPOSITE_HID_CLASS);
	/* Start Device Process */
	USBD_Start(&hUSBD_Device_HID);
	#endif // USBD_USE_HID_COMPOSITE
	}

as weak so that users can redefine it in order to implement USB features in sketches or external libraries?

Thanks in advance and best, E.

[fpistm]

Yes (at this moment).
As mentioned in other Issuer/PR this will be removed as USB will be moved in builtin library.

[edogaldo]

Thank you @fpistm.
Which are the planning for including UBS?
In my opinion it would anyway be better to embed it as an external library that can be included if needed in order to avoid useled code bloating if not needed.
Going back to my question and your answer, "Yes (at this moment)", does it mean you will change

void usbd_interface_init(void)
{
  ...
}

to

__attribute__((weak))
void usbd_interface_init(void)
{
  ...
}

in the meantime?

Thanks, E.

[fpistm]

I've answered here to @hasenbanck
#222 (comment)
What I would mean by "at this moment" is this part will be reviewed.

[fpistm]

I guess this issue will be deprecated with #344

[edogaldo]

Well, the aim of this issue is to request the possibility for the user to be able to define his own USB initialization procedure, possibly also at sketch level (and not only at variant level).
Any solution which goes in that direction is fine for me.

Cheers, E.