Skip to content

V3 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2022
Merged

V3 #79

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
428 changes: 395 additions & 33 deletions README.md

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions app/assets/stylesheets/active_sessions.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Place all the styles related to the active_sessions controller here.
// They will automatically be included in application.css.
// You can use Sass (SCSS) here: https://sass-lang.com/
25 changes: 25 additions & 0 deletions app/controllers/active_sessions_controller.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
class ActiveSessionsController < ApplicationController
before_action :authenticate_user!

def destroy
@active_session = current_user.active_sessions.find(params[:id])

@active_session.destroy

if current_user
redirect_to account_path, notice: "Session deleted."
else
forget_active_session
reset_session
redirect_to root_path, notice: "Signed out."
end
end

def destroy_all
forget_active_session
current_user.active_sessions.destroy_all
reset_session

redirect_to root_path, notice: "Signed out."
end
end
32 changes: 16 additions & 16 deletions app/controllers/concerns/authentication.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,45 +14,45 @@ def authenticate_user!

def login(user)
reset_session
user.regenerate_session_token
session[:current_user_session_token] = user.reload.session_token
active_session = user.active_sessions.create!(user_agent: request.user_agent, ip_address: request.ip)
session[:current_active_session_id] = active_session.id

active_session
end

def forget(user)
def forget_active_session
cookies.delete :remember_token
user.regenerate_remember_token
end

def logout
user = current_user
active_session = ActiveSession.find_by(id: session[:current_active_session_id])
reset_session
user.regenerate_session_token
active_session.destroy! if active_session.present?
end

def redirect_if_authenticated
redirect_to root_path, alert: "You are already logged in." if user_signed_in?
end

def remember(user)
user.regenerate_remember_token
cookies.permanent.encrypted[:remember_token] = user.remember_token
end

def store_location
session[:user_return_to] = request.original_url if request.get? && request.local?
def remember(active_session)
cookies.permanent.encrypted[:remember_token] = active_session.remember_token
end

private

def current_user
Current.user ||= if session[:current_user_session_token].present?
User.find_by(session_token: session[:current_user_session_token])
Current.user = if session[:current_active_session_id].present?
ActiveSession.find_by(id: session[:current_active_session_id])&.user
elsif cookies.permanent.encrypted[:remember_token].present?
User.find_by(remember_token: cookies.permanent.encrypted[:remember_token])
ActiveSession.find_by(remember_token: cookies.permanent.encrypted[:remember_token])&.user
end
end

def user_signed_in?
Current.user.present?
end

def store_location
session[:user_return_to] = request.original_url if request.get? && request.local?
end
end
6 changes: 3 additions & 3 deletions app/controllers/sessions_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ def create
redirect_to new_confirmation_path, alert: "Incorrect email or password."
else
after_login_path = session[:user_return_to] || root_path
login @user
remember(@user) if params[:user][:remember_me] == "1"
active_session = login @user
remember(active_session) if params[:user][:remember_me] == "1"
redirect_to after_login_path, notice: "Signed in."
end
else
Expand All @@ -20,7 +20,7 @@ def create
end

def destroy
forget(current_user)
forget_active_session
logout
redirect_to root_path, notice: "Signed out."
end
Expand Down
2 changes: 2 additions & 0 deletions app/controllers/users_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def destroy

def edit
@user = current_user
@active_sessions = @user.active_sessions.order(created_at: :desc)
end

def new
Expand All @@ -28,6 +29,7 @@ def new

def update
@user = current_user
@active_sessions = @user.active_sessions.order(created_at: :desc)
if @user.authenticate(params[:user][:current_password])
if @user.update(update_user_params)
if params[:user][:unconfirmed_email].present?
Expand Down
2 changes: 2 additions & 0 deletions app/helpers/active_sessions_helper.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
module ActiveSessionsHelper
end
5 changes: 5 additions & 0 deletions app/models/active_session.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class ActiveSession < ApplicationRecord
belongs_to :user

has_secure_token :remember_token
end
4 changes: 2 additions & 2 deletions app/models/user.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ class User < ApplicationRecord
attr_accessor :current_password

has_secure_password
has_secure_token :remember_token
has_secure_token :session_token

has_many :active_sessions, dependent: :destroy

before_save :downcase_email
before_save :downcase_unconfirmed_email
Expand Down
6 changes: 6 additions & 0 deletions app/views/active_sessions/_active_session.html.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<tr>
<td><%= active_session.user_agent %></td>
<td><%= active_session.ip_address %></td>
<td><%= active_session.created_at %></td>
<td><%= button_to "Sign Out", active_session_path(active_session), method: :delete %></td>
</tr>
2 changes: 1 addition & 1 deletion app/views/sessions/new.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<%= form_with url: login_path, scope: :user do |form| %>
<div>
<%= form.label :email %>
<%= form.text_field :email, required: true %>
<%= form.email_field :email, required: true %>
</div>
<div>
<%= form.label :password %>
Expand Down
19 changes: 18 additions & 1 deletion app/views/users/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<%= render partial: "shared/form_errors", locals: { object: form.object } %>
<div>
<%= form.label :email, "Current Email" %>
<%= form.text_field :email, disabled: true %>
<%= form.email_field :email, disabled: true %>
</div>
<div>
<%= form.label :unconfirmed_email, "New Email" %>
Expand All @@ -22,4 +22,21 @@
<%= form.password_field :current_password, required: true %>
</div>
<%= form.submit "Update Account" %>
<% end %>
<h2>Current Logins</h2>
<% if @active_sessions.any? %>
<%= button_to "Log out of all other sessions", destroy_all_active_sessions_path, method: :delete %>
<table>
<thead>
<tr>
<th>User Agent</th>
<th>IP Address</th>
<th>Signed In At</th>
<th>Sign Out</th>
</tr>
</thead>
<tbody>
<%= render @active_sessions %>
</tbody>
</table>
<% end %>
2 changes: 1 addition & 1 deletion app/views/users/new.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<%= render partial: "shared/form_errors", locals: { object: form.object } %>
<div>
<%= form.label :email %>
<%= form.text_field :email, required: true %>
<%= form.email_field :email, required: true %>
</div>
<div>
<%= form.label :password %>
Expand Down
5 changes: 5 additions & 0 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,9 @@
delete "logout", to: "sessions#destroy"
get "login", to: "sessions#new"
resources :passwords, only: [:create, :edit, :new, :update], param: :password_reset_token
resources :active_sessions, only: [:destroy] do
collection do
delete "destroy_all"
end
end
end
6 changes: 0 additions & 6 deletions db/migrate/20211217184706_add_session_token_to_users.rb

This file was deleted.

9 changes: 9 additions & 0 deletions db/migrate/20220129144819_create_active_sessions.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
class CreateActiveSessions < ActiveRecord::Migration[6.1]
def change
create_table :active_sessions do |t|
t.references :user, null: false, foreign_key: {on_delete: :cascade}

t.timestamps
end
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class AddRequestColumnsToActiveSessions < ActiveRecord::Migration[6.1]
def change
add_column :active_sessions, :user_agent, :string
add_column :active_sessions, :ip_address, :string
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# TODO: Remove comment
# rails g migration move_remember_token_from_users_to_active_sessions
class MoveRememberTokenFromUsersToActiveSessions < ActiveRecord::Migration[6.1]
def change
remove_column :users, :remember_token
add_column :active_sessions, :remember_token, :string, null: false

add_index :active_sessions, :remember_token, unique: true
end
end
18 changes: 13 additions & 5 deletions db/schema.rb

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 68 additions & 0 deletions test/controllers/active_sessions_controller_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
require "test_helper"

class ActiveSessionsControllerTest < ActionDispatch::IntegrationTest
setup do
@confirmed_user = User.create!(email: "confirmed_user@example.com", password: "password", password_confirmation: "password", confirmed_at: Time.current)
end

test "should destroy all active sessions" do
login @confirmed_user
@confirmed_user.active_sessions.create!

assert_difference("ActiveSession.count", -2) do
delete destroy_all_active_sessions_path
end

assert_redirected_to root_path
assert_nil current_user
assert_not_nil flash[:notice]
end

test "should destroy all active sessions and forget active sessions" do
login @confirmed_user, remember_user: true
@confirmed_user.active_sessions.create!

assert_difference("ActiveSession.count", -2) do
delete destroy_all_active_sessions_path
end

assert_nil current_user
assert cookies[:remember_token].blank?
end

test "should destroy another session" do
login @confirmed_user
@confirmed_user.active_sessions.create!

assert_difference("ActiveSession.count", -1) do
delete active_session_path(@confirmed_user.active_sessions.last)
end

assert_redirected_to account_path
assert_not_nil current_user
assert_not_nil flash[:notice]
end

test "should destroy current session" do
login @confirmed_user

assert_difference("ActiveSession.count", -1) do
delete active_session_path(@confirmed_user.active_sessions.last)
end

assert_redirected_to root_path
assert_nil current_user
assert_not_nil flash[:notice]
end

test "should destroy current session and forget current active session" do
login @confirmed_user, remember_user: true

assert_difference("ActiveSession.count", -1) do
delete active_session_path(@confirmed_user.active_sessions.last)
end

assert_nil current_user
assert cookies[:remember_token].blank?
end
end
Loading