fix xcode-10.2 issues

[ottosuess]

resolves #888

In Xcode 10.2 beta 4 the macro #function shows a different behaviour. As SQLite.swift relies on #function in different subroutines for the composition of SQLite queries, several bugs linked to invalid SQLite statements seem to be introduced.

I replaced all the #function magic by static strings.

[tanzolone]

Good idea getting rid of the #function.
However I would suggest avoiding using multiple duplicated string literals all over the place (as they are harder to refactor and error prone). A form of mapping might be helpful here: e.g.

enum Function: String {
case count
case greaterThan = ">"
...
}

[tanzolone]

Thanks for fixing this, looks great! I have a couple of small suggestions.

[tanzolone]

enum name should be singular e.g. Function

[ypopovych]

Updated

[tanzolone]

as a convention case name should be lower case - I'd personally change those (e.g. case like = "LIKE")

[ypopovych]

Yep. I think the common naming style is better. Updated.

[tanzolone]

Ditto, better singular Operator

[ypopovych]

Fixed.

[tanzolone]

This look good - could you kindly have a look at the failing CI checks?

[ypopovych]

Travis bug. Couldn't start watch simulator

…

On Thu, 28 Mar 2019, 10:10 Antonio Tanzola, ***@***.***> wrote: This look good - could you kindly have a look at the failing CI checks? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#891 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFMkUQ4gF_BeSbOT6QZ4XM0BCCRHFzKks5vbHkDgaJpZM4cLQ94> .

[ypopovych]

@stephencelis What do you think? Can you merge it? The library doesn't work in Xcode 10.2 at all :(

[sznowicki]

Just wanted to thank you @ypopovych for this work.

[stephencelis]

Thanks! Sorry for the delay. I'll also added you as a contributor if you'd like to help continue unblock these kinds of things in the future.

[eschao]

@here: After updated codes to latest, I still get unrecognized token: ":" error when count table. Is it really solved? Thanks!

[nickgzzjr]

@eschao The version in the podspec has not gotten bumped so your CocoaPods is probably caching the pod. You could clear your CocoaPods cache, you could point directly to this git repo, or you could wait until they bump the version. 😄 I had pointed to ottosuess's git repo and all the errors had gone away.

[wddwycc]

@stephencelis could you please make a release for this PR ?

[eschao]

@nickgzzjr No cocoapods, I use carthage, I deleted all including carthage checkout, carthage build and cache, and then updated again. but the problem is still existing. Any step I missed or made wrong?

[mitesh-iosdev]

@stephencelis could you please make a release for this PR ?

Please update ASAP if the issue is fixed.

[PatoSalazarNascent]

@stephencelis Did this update got released in a new version of the pod?? I just updated mine to 0.12.0 but I am still having the issue...

[tuchangwei]

@eschao The version in the podspec has not gotten bumped so your CocoaPods is probably caching the pod. You could clear your CocoaPods cache, you could point directly to this git repo, or you could wait until they bump the version. 😄 I had pointed to ottosuess's git repo and all the errors had gone away.

I pointed to ottosuess's git repo, but I still get the error:

created_at > date

use asSQL() function to convert to sql

"created_at" >(_:_:) 0.0

[ypopovych]

It should work from CocoaPods. 0.12.0