Skip to content

Created a single universal Mac+iOS framework #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Created a single universal Mac+iOS framework #1

wants to merge 1 commit into from

Conversation

marcprux
Copy link

No description provided.

@@ -9,17 +9,6 @@ A pure [Swift][1.1] framework wrapping [SQLite3][1.2].
[1.3]: https://github.com/stephencelis/SQLite.swift


## Features
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, did my recent README changes somehow get reverted in your commit?

@stephencelis
Copy link
Owner

This is really interesting, but it looks like it accidentally reverts a few recent commits. Could you re-commit and force-push just your changes so I can investigate further?

@marcprux
Copy link
Author

Sorry, I was away for the past few days. Do you happen to know how to force-push updates to a fork?

On Oct 14, 2014, at 12:46 AM, Stephen Celis notifications@github.com wrote:

This is really interesting, but it looks like it accidentally reverts a few recent commits. Could you re-commit and force-push just your changes so I can investigate further?


Reply to this email directly or view it on GitHub #1 (comment).

@stephencelis
Copy link
Owner

@mprudhom Sorry, I'm traveling as well! You should be able to clone your fork, amend your commit and git push -f the same branch.

@stephencelis
Copy link
Owner

Hm, I've tried to replicate this with a new branch:

https://github.com/stephencelis/SQLite.swift/tree/universal-framework

But It's complaining on the build server:

https://travis-ci.org/stephencelis/SQLite.swift/builds/47314796

And, while the CLI build works fine locally on my MacBook using -sdk macosx:

$ xcodebuild -scheme SQLite -sdk macosx test
Build settings from command line:
    SDKROOT = macosx10.10

=== BUILD TARGET SQLite OF PROJECT SQLite WITH CONFIGURATION Debug ===

Check dependencies

=== BUILD TARGET SQLite Tests OF PROJECT SQLite WITH CONFIGURATION Debug ===

Check dependencies
…
** TEST SUCCEEDED **

I'm having issues with iphonesimulator:

$ xcodebuild -scheme SQLite -sdk iphonesimulator test ONLY_ACTIVE_ARCH=NO
Build settings from command line:
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = iphonesimulator8.1

=== BUILD TARGET SQLite OF PROJECT SQLite WITH CONFIGURATION Debug ===

Check dependencies
No architectures to compile for (ARCHS=x86_64, VALID_ARCHS=arm64 armv7 armv7s).


Testing failed:
    No architectures to compile for (ARCHS=x86_64, VALID_ARCHS=arm64 armv7 armv7s).
** TEST FAILED **


The following build commands failed:
    Check dependencies
(1 failure)

@stephencelis
Copy link
Owner

Finally closing in favor of d6e752c

It makes Travis unhappy (see travis-ci/travis-ci#3237), but everything else seems to be in order.

@tuchangwei tuchangwei mentioned this pull request Apr 9, 2016
jberkel pushed a commit that referenced this pull request Jul 1, 2017
Updating swift 4 branch from master
stephanheilner referenced this pull request in stephanheilner/SQLite.swift Mar 27, 2019
Commented out check breaking queries
stephencelis pushed a commit that referenced this pull request Mar 30, 2019
Strings to enum constants
thomasrzhao referenced this pull request in thomasrzhao/SQLite.swift Jan 20, 2020
nathanfallet pushed a commit that referenced this pull request Mar 27, 2022
Add prepareRowIterator method to an extension of Statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants