-
Notifications
You must be signed in to change notification settings - Fork 41
Fix invalid array index validation to reject indices with leading zeros #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
7
commits into
master
Choose a base branch
from
copilot/fix-63
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: stefankoegl <184196+stefankoegl@users.noreply.github.com>
Copilot finished work on behalf of
stefankoegl
May 27, 2025 21:22
@copilot please fix that whitespace issue that is reported by flake8 |
Co-authored-by: stefankoegl <184196+stefankoegl@users.noreply.github.com>
Fixed the whitespace issue in tests.py (line 222 had trailing whitespace). The flake8 checks now pass without any errors. Commit: c7b4416 |
Copilot finished work on behalf of
stefankoegl
May 28, 2025 09:19
@copilot rebase |
…ility code Co-authored-by: stefankoegl <184196+stefankoegl@users.noreply.github.com>
Co-authored-by: stefankoegl <184196+stefankoegl@users.noreply.github.com>
Copilot finished work on behalf of
stefankoegl
June 10, 2025 21:39
stefankoegl
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current regex pattern used to validate array indices in the
jsonpointer
package incorrectly accepts indices with leading zeros (such as "01", "00", "0123"), which violates the JSON Pointer specification (RFC 6901).Root Cause
The current regex pattern has a logical flaw:
This pattern:
0|[1-9][0-9]*$
)^
)Fix
Updated the regex pattern to properly validate array indices according to RFC 6901:
This fix:
^
(?:...)
for efficiencyAdded Tests
Added tests to verify that invalid array indices with leading zeros are properly rejected:
All tests pass, confirming that the fix works correctly and doesn't break existing functionality.
Fixes #63.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.