Skip to content

feat!: migrate to using stdlib complex number types #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

steff456
Copy link
Contributor

Part of https://github.com/stdlib-js/todo/issues/1454

Description

What is the purpose of this pull request?

This pull request:

  • Adds addon with tests, examples and readme update

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

Locally I'm seeing this error when running the c benchmark,

Running benchmark: /Users/tefa/Documents/stdlib/lib/node_modules/@stdlib/math/base/special/cceil/benchmark/c/native/benchmark.c
Resolving package path...
Package path: /Users/tefa/Documents/stdlib/lib/node_modules/@stdlib/math/base/special/cceil
Resolving package manifest...
Successfully resolved package manifest.
Resolving include directories...
Resolving source files...
Resolving libraries...
Resolving library paths...
Compiling benchmark...
In file included from /Users/tefa/Documents/stdlib/lib/node_modules/@stdlib/math/base/napi/unary/src/main.c:19:
/Users/tefa/Documents/stdlib/lib/node_modules/@stdlib/math/base/napi/unary/include/stdlib/math/base/napi/unary.h:24:10: fatal error: 
      'node_api.h' file not found
#include <node_api.h>
         ^~~~~~~~~~~~
1 error generated.
make[1]: *** [benchmark.out] Error 1
Error when attempting to compile benchmark.
ERROR: An error was encountered during execution.

make: *** [benchmark-c] Error 1

I'm not sure how to fix it... I'll doubled checked everything 😅

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@steff456 steff456 added Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Feb 21, 2023
@steff456 steff456 requested a review from kgryte February 21, 2023 18:25
@steff456 steff456 self-assigned this Feb 21, 2023
@kgryte kgryte changed the title feat: Add native addon to cceil feat: add native addon to cceil Feb 22, 2023
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

@kgryte kgryte changed the title feat: add native addon to cceil feat!: migrate to using stdlib complex number types Feb 24, 2023
@kgryte kgryte merged commit 4ca9916 into develop Feb 24, 2023
@kgryte kgryte deleted the cceil-addon branch February 24, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants