Skip to content

feat: add native addon to cabs2 #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 23, 2023
Merged

feat: add native addon to cabs2 #912

merged 5 commits into from
Feb 23, 2023

Conversation

steff456
Copy link
Contributor

Part of https://github.com/stdlib-js/todo/issues/1454

Description

What is the purpose of this pull request?

This pull request:

  • Adds addon with tests, examples and readme update

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@steff456 steff456 added Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Feb 20, 2023
@steff456 steff456 requested a review from kgryte February 20, 2023 16:53
@steff456 steff456 self-assigned this Feb 20, 2023
@kgryte kgryte changed the title FEAT: Add native addon to cabs2 feat: add native addon to cabs2 Feb 20, 2023
This is necessary to avoid running tests if an add-on is not compiled.
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

@kgryte kgryte merged commit 119e99d into develop Feb 23, 2023
@kgryte kgryte deleted the cabs2-addon branch February 23, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants