Skip to content

Refactor @stdlib/blas/base/dswap #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 18, 2023
Merged

Refactor @stdlib/blas/base/dswap #793

merged 10 commits into from
Jan 18, 2023

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jan 17, 2023 •
edited
Loading

Checklist

  • update readme.md
  • docs
  • include/stdlib/blas/base ( No such change visible )
  • src
  • include.gypi
  • manifest.json
  • package.json
  • lib
  • examples
  • benchmark
  • test

@kgryte

@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Jan 17, 2023
@Pranavchiku Pranavchiku marked this pull request as ready for review January 17, 2023 10:28
@Pranavchiku
Copy link
Member Author

All tests and benchmarks cleared. I guess some minor updates need to be done like removing unnecessary dependencies in manifest.json, and removing to swap from some files. I will do that asap.
Except those this PR can have a review.

@Pranavchiku
Copy link
Member Author

All tests and benchmarks cleared. This PR can have a review :)

kgryte
kgryte approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku!

@kgryte kgryte merged commit 053ce44 into stdlib-js:develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte