Skip to content

feat: add stats/array/max-by #7130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 1, 2025
Merged

feat: add stats/array/max-by #7130

merged 20 commits into from
Jun 1, 2025

Conversation

gururaj1512
Copy link
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • feat: add stats/array/max-by

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels May 30, 2025
@gururaj1512 gururaj1512 added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels May 31, 2025
gururaj1512
gururaj1512 commented May 31, 2025
View reviewed changes
kgryte
kgryte reviewed May 31, 2025
View reviewed changes
@kgryte
Copy link
Member

kgryte commented May 31, 2025

/stdlib merge

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label May 31, 2025
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 31, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 31, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 31, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/array/max-by $\color{green}94/94$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}94/94$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed May 31, 2025
View reviewed changes
@kgryte
docs: fix signature
1a280b1 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed May 31, 2025
View reviewed changes
kgryte
kgryte reviewed May 31, 2025
View reviewed changes
kgryte added 3 commits May 31, 2025 15:59
@kgryte
fix: update callback invocation logic to ensure correct arguments
a0a285d 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
style: fix indentation
f1ffd8b 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
style: fix indentation
c052abb 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes May 31, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the implementation. Docs and likely tests/examples should be updated accordingly.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels May 31, 2025
@gururaj1512
docs: update docs as suggested in docs
a1854c0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jun 1, 2025
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
@kgryte
docs: update copy
10751e7 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
@kgryte
docs: update copy
5921c13 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
dc5316a 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
b9df70b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
@kgryte
test: update descriptions
ed38422 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
@kgryte
test: update descriptions
69df539 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
kgryte added 2 commits June 1, 2025 01:36
@kgryte
test: add test
7a0df50 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
test: update callback tests
6fda0bd 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 1, 2025
@kgryte
Copy link
Member

kgryte commented Jun 1, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 1, 2025
@kgryte kgryte mentioned this pull request Jun 1, 2025
Merged
1 task
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 1, 2025
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 1, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
210584d 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte merged commit 8908678 into stdlib-js:develop Jun 1, 2025
11 checks passed
@gururaj1512 gururaj1512 mentioned this pull request Jun 2, 2025
Open
@gururaj1512 gururaj1512 deleted the stats-array-max-by branch June 3, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gururaj1512 @kgryte @stdlib-bot