feat: add `math/base/special/kernel-sinf` #6191

Girish-Garg · 2025-03-19T09:43:44Z

Porgresses #649 .

Description

What is the purpose of this pull request?

This pull request:

feat: add JS and C implementation of math/base/special/kernelSinf function

Related Issues

Does this pull request have any related issues?

This pull request:

progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

stdlib-bot · 2025-03-19T09:45:51Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/kernel-sinf	$\color{red}283/287$ $\color{green}+98.61\%$	$\color{red}9/11$ $\color{green}+81.82\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{red}283/287$ $\color{green}+98.61\%$

The above coverage report was generated for the changes in this PR.

Girish-Garg · 2025-03-19T09:54:43Z

@kgryte all the things are done for kernelSinf except test cases which required rempio2f that is causing 7-10% test cases with tolerance(no strickEqual as before) in JS implementation and greater tolerance in C implementation which should be resolved when rempio2f PR will be merged although i have modified test cases for tolerance as well
All the other parts are ready to review. Thanks

Girish-Garg · 2025-04-29T19:55:38Z

/stdlib update-copyright-years

anandkaranubc · 2025-06-04T00:42:06Z

/stdlib merge

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

anandkaranubc · 2025-06-04T01:42:21Z

Referenced from https://svnweb.freebsd.org/base/release/12.2.0/lib/msun/src/k_sinf.c?view=markup

Confirmed with Julia's https://github.com/JuliaLang/julia/blob/760b2e5b7396f9cc0da5efce0cadd5d1974c4069/base/special/trig.jl#L85

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/math/base/special/kernel-sinf/README.md

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/math/base/special/kernel-sinf/examples/c/example.c

anandkaranubc · 2025-06-04T02:24:25Z

@Planeshifter I have propagated the same changes here 😄

Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>

lib/node_modules/@stdlib/math/base/special/kernel-sinf/README.md

lib/node_modules/@stdlib/math/base/special/kernel-sinf/src/main.c

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter

Looks great; thanks, @Girish-Garg and @anandkaranubc!

stdlib-bot · 2025-06-04T22:41:26Z

PR Commit Message

feat: add `math/base/special/kernel-sinf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6191
Ref: https://github.com/stdlib-js/stdlib/issues/649

Co-authored-by: Girish Garg <garggirish2020@gmail.com>
Co-authored-by: Karan Anand <anandkarancompsci@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

Girish-Garg · 2025-06-05T06:55:35Z

@anandkaranubc great to see that it merged 👍

anandkaranubc · 2025-06-05T06:57:32Z

@anandkaranubc great to see that it merged 👍

Haha had to change quite a bit. But hopefully the changes can serve as a helpful reference for your future implementations. Cheers!

feat: add JS and C implementation of kernelSinf function

9f54aa2

stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Mar 19, 2025

Girish-Garg mentioned this pull request Mar 22, 2025

[RFC]: developer dashboard for tracking ecosystem build failures stdlib-js/google-summer-of-code#110

Closed

7 tasks

Girish-Garg changed the title ~~feat: add JS and C implementation of kernelSinf function~~ feat: add math/base/special/kernelSinf Apr 16, 2025

stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Apr 29, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 29, 2025

chore: update copyright years

c9868cb

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 29, 2025

anandkaranubc self-requested a review June 4, 2025 00:25

stdlib-bot added the Needs Review A pull request which needs code review. label Jun 4, 2025

anandkaranubc marked this pull request as ready for review June 4, 2025 00:27

anandkaranubc changed the title ~~feat: add math/base/special/kernelSinf~~ feat: add math/base/special/kernel-sinf Jun 4, 2025

anandkaranubc added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. labels Jun 4, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 4, 2025

Merge remote-tracking branch 'upstream/develop' into feat/kernel-sinf

bd89c02

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 4, 2025

anandkaranubc previously approved these changes Jun 4, 2025

View reviewed changes

anandkaranubc added the priority: High High priority concern or feature request. label Jun 4, 2025

anandkaranubc dismissed their stale review via eb143e6 June 4, 2025 01:46

Planeshifter reviewed Jun 4, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/kernel-sinf/README.md Outdated Show resolved Hide resolved

anandkaranubc added 2 commits June 3, 2025 18:48

Planeshifter reviewed Jun 4, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/kernel-sinf/examples/c/example.c Outdated Show resolved Hide resolved

Update README.md

180ca75

Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>

Planeshifter reviewed Jun 4, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/kernel-sinf/README.md Outdated Show resolved Hide resolved

Planeshifter reviewed Jun 4, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/kernel-sinf/src/main.c Outdated Show resolved Hide resolved

Planeshifter approved these changes Jun 4, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 4, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 4, 2025

Planeshifter merged commit c037257 into stdlib-js:develop Jun 4, 2025
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `math/base/special/kernel-sinf` #6191

feat: add `math/base/special/kernel-sinf` #6191

Uh oh!

Girish-Garg commented Mar 19, 2025

Uh oh!

stdlib-bot commented Mar 19, 2025 •

edited

Loading

Uh oh!

Girish-Garg commented Mar 19, 2025 •

edited

Loading

Uh oh!

Girish-Garg commented Apr 29, 2025

Uh oh!

anandkaranubc commented Jun 4, 2025

Uh oh!

anandkaranubc commented Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

anandkaranubc commented Jun 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment •

edited

Loading

Uh oh!

stdlib-bot commented Jun 4, 2025

Uh oh!

Uh oh!

Girish-Garg commented Jun 5, 2025

Uh oh!

anandkaranubc commented Jun 5, 2025

Uh oh!

Uh oh!

Uh oh!

feat: add math/base/special/kernel-sinf #6191

feat: add math/base/special/kernel-sinf #6191

Uh oh!

Conversation

Girish-Garg commented Mar 19, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Girish-Garg commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Girish-Garg commented Apr 29, 2025

Uh oh!

anandkaranubc commented Jun 4, 2025

Uh oh!

anandkaranubc commented Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

anandkaranubc commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jun 4, 2025

PR Commit Message

Uh oh!

Uh oh!

Girish-Garg commented Jun 5, 2025

Uh oh!

anandkaranubc commented Jun 5, 2025

Uh oh!

Uh oh!

feat: add `math/base/special/kernel-sinf` #6191

feat: add `math/base/special/kernel-sinf` #6191

stdlib-bot commented Mar 19, 2025 •

edited

Loading

Girish-Garg commented Mar 19, 2025 •

edited

Loading

anandkaranubc commented Jun 4, 2025 •

edited

Loading

Planeshifter left a comment •

edited

Loading