Skip to content

Fixed some indent style errors and updated manifest.json #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bhavishy2801
Copy link
Contributor

@bhavishy2801 bhavishy2801 commented Mar 17, 2025

Resolves #6053.

Description

What is the purpose of this pull request?

This pull request:

• Fixes EditorConfig linting issues by converting tabs to spaces in the following files:
> lib/node_modules/@stdlib/ndarray/base/bytes-per-element/manifest.json
> lib/node_modules/@stdlib/strided/ndapi/addon-arguments/manifest.json
• Ensures consistency with .editorconfig rules for indentation (spaces instead of tabs).
• Updates affected JSON files without modifying their structure or content.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: Bhavishy Agrawal <90029607+bhavishy2801@users.noreply.github.com>
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 17, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/bytes-per-element $\color{green}91/91$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}91/91$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 17, 2025
@bhavishy2801 bhavishy2801 reopened this Mar 17, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 17, 2025
@aayush0325 aayush0325 added Duplicate This issue or pull request already exists. Needs Review A pull request which needs code review. labels Mar 17, 2025
@aayush0325
Copy link
Member

#6057 already addresses this issue. kindly cross check whether a good PR already exists for the issue that you're trying to work on to avoid conflicts like these

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 17, 2025
@kgryte
Copy link
Member

kgryte commented Mar 17, 2025

As #6053 has already been resolved, I'll go ahead and close this PR.

@kgryte kgryte closed this Mar 17, 2025
@bhavishy2801 bhavishy2801 deleted the bhavishy2801-patch-1 branch March 19, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
4 participants