Skip to content

feat: refactor and add protocol support to stats/base/variancepn #5854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: refactor and add protocol support to stats/base/variancepn #5854

wants to merge 1 commit into from

Conversation

thefauxpastrouper
Copy link

Resolves #5689 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds accessor arrays support.
  • Refactors stats/base/variancepn.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

feat: refactor and add protocol support to stats/base/variancepn
877c47f 
- Adds accessor arrays support.
- Refactors `stats/base/variancepn`.

Does this pull request have any related issues?

- No

Any questions for reviewers of this pull request?

- No.

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

- No.

Please ensure the following tasks are completed before submitting this pull request.

- [ ] Read, understood, and followed the contributing guidelines.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 7, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/variancepn $\color{red}344/348$
$\color{green}+98.85\%$ 		$\color{red}20/22$
$\color{green}+90.91\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{red}344/348$
$\color{green}+98.85\%$

The above coverage report was generated for the changes in this PR.

@thefauxpastrouper
Copy link
Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Mar 7, 2025
@thefauxpastrouper
Copy link
Author

/stdlib auto-lint

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Mar 7, 2025
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@kgryte kgryte changed the title feat: refactor and add protocol support to stats/base/variancepn feat: refactor and add protocol support to stats/base/variancepn Jun 8, 2025
@kgryte kgryte requested a review from gururaj1512 June 8, 2025 09:00
@gururaj1512 gururaj1512 added the Duplicate This issue or pull request already exists. label Jun 12, 2025
@kgryte
Copy link
Member

kgryte commented Jun 13, 2025

Ref: #5829

@kgryte kgryte added autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels Jun 13, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gururaj1512 gururaj1512 Awaiting requested review from gururaj1512

Assignees
No one assigned
Labels
autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Duplicate This issue or pull request already exists. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/variancepn
5 participants
@thefauxpastrouper @stdlib-bot @kgryte @Planeshifter @gururaj1512