feat: add `assert/has-same-constructor` #5446

abhishekblue · 2025-02-25T18:26:19Z

type: pre_push_report
description: Results of running various checks prior to pushing changes. report:

task: run_javascript_examples status: na
task: run_c_examples status: na
task: run_cpp_examples status: na
task: run_javascript_readme_examples status: na
task: run_c_benchmarks status: na
task: run_cpp_benchmarks status: na
task: run_fortran_benchmarks status: na
task: run_javascript_benchmarks status: na
task: run_julia_benchmarks status: na
task: run_python_benchmarks status: na
task: run_r_benchmarks status: na
task: run_javascript_tests status: na ---

Resolves #815.

Description

What is the purpose of this pull request?

This pull request:

Adds a fully implemented hasSameConstructor utility to the @stdlib/assert/ namespace to test if two values have the same constructor.

Related Issues

Does this pull request have any related issues?

This pull request:

Resolves [RFC]: Add @stdlib/assert/has-same-constructor #815

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-02-25T18:27:54Z

Coverage Report

Package	Statements	Branches	Functions	Lines
assert/has-same-constructor	$\color{green}98/98$ $\color{green}+100.00\%$	$\color{green}6/6$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}98/98$ $\color{green}+100.00\%$
assert	$\color{green}2733/2733$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}0/0$ $\color{green}+100.00\%$	$\color{green}2733/2733$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed ---

anandkaranubc · 2025-02-26T19:05:56Z

/stdlib lint-autofix

anandkaranubc · 2025-02-26T19:08:57Z

@abhishekblue Thanks for working on this issue. That looks like a good starting point.

The first step here is to ensure that every comment in this PR has been addressed in this one. Also, other similar packages in assert/* will be a good reference point too.

Can you also change the title to:

feat: add assert/has-same-constructor

anandkaranubc · 2025-02-26T19:12:14Z

This will also resolve the CI failures you're currently experiencing.

anandkaranubc · 2025-02-26T19:15:25Z

lib/node_modules/@stdlib/assert/has-same-constructor/test/test.js

+	t.end();
+});
+
+tape( 'compare two null values', function test( t ) {


The test descriptions in this file should be more descriptive and follow project's code conventions. Looking at other packages would be useful to fix this.

anandkaranubc · 2025-02-26T19:16:48Z

lib/node_modules/@stdlib/assert/has-same-constructor/lib/main.js

+* // returns true
+*
+*/
+
+function hasSameConstructor( x, y ) {


Suggested change

* // returns true

*

*/

function hasSameConstructor( x, y ) {

* // returns true

*/

function hasSameConstructor( x, y ) {

Make sure you are following correct spacing conventions throughout this PR.

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed ---

abhishekblue · 2025-02-28T08:59:17Z

@Neerajpathak07 @anandkaranubc, I’ve been working on this PR but I’m struggling to pass the tests despite multiple attempts. Could you please provide some guidance or point me to resources that might help me resolve these issues? I’d really appreciate your support. Thanks!

kgryte · 2025-02-28T09:51:46Z

lib/node_modules/@stdlib/assert/package.json

@@ -30,8 +30,10 @@
  "bugs": {
    "url": "https://github.com/stdlib-js/stdlib/issues"
  },
-  "dependencies": {},
-  "devDependencies": {},
+  "dependencies": {


In absolutely no circumstances should you be editing this file in this PR. These dependencies should be removed.

I must've accidentally edited this file. Apologies for this!

kgryte · 2025-02-28T09:52:34Z

lib/node_modules/@stdlib/assert/has-same-constructor/test/test.js

+});
+
+tape( 'the function returns `true` if provided two arguments which have the same constructor', function test ( t ) {
+    var values;


Please make sure you have installed and setup EditorConfig. You have mixed tabs and spaces throughout this file. You can find more instructions in our contributing and development guides.

kgryte · 2025-02-28T09:54:18Z

lib/node_modules/@stdlib/assert/has-same-constructor/test/test.js

+    var bool;
+    var i;
+
+    values =[


You need to rethink these tests. Testing built-in primitives isn't particularly interesting. The entire purpose of this API is to determine whether two class instances share the same original constructor.

@kgryte, thank you for your feedback. To confirm, should I create custom classes and their constructors and run tests specifically on those constructors to determine whether class instances share the same original constructor? Just want to be sure before proceeding further.

kgryte · 2025-02-28T09:56:10Z

lib/node_modules/@stdlib/assert/has-same-constructor/lib/main.js

+* // returns true
+*/
+function hasSameConstructor( x, y ) {
+    if ( x === null || y === null ) {


What about undefined?

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 25, 2025

abhishekblue changed the title ~~feat(assert): Add @stdlib/assert/has-same-constructor~~ feat(assert): add hasSameConstructor Feb 25, 2025

abhishekblue added 2 commits February 26, 2025 00:29

style(assert): fix lint errors in has-same-constructor

81737cd

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 26, 2025

fix: resolve lint errors

6cad99b

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 26, 2025

anandkaranubc added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 26, 2025

anandkaranubc reviewed Feb 26, 2025

View reviewed changes

abhishekblue changed the title ~~feat(assert): add hasSameConstructor~~ feat: add assert/has-same-constructor Feb 26, 2025

abhishekblue added 2 commits February 27, 2025 03:20

stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Feb 27, 2025

abhishekblue added 2 commits February 28, 2025 13:52

fix(assert): resolve README lint errors and improve formatting

04bcb74

adjust main.js

f3f9218

kgryte reviewed Feb 28, 2025

View reviewed changes

kgryte changed the title ~~feat: add assert/has-same-constructor~~ feat: add assert/has-same-constructor Feb 28, 2025

abhishekblue mentioned this pull request Mar 31, 2025

[RFC]: Automated Code Reviews and Fixes via LLM-powered stdlib-bot stdlib-js/google-summer-of-code#124

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `assert/has-same-constructor` #5446

feat: add `assert/has-same-constructor` #5446

Uh oh!

abhishekblue commented Feb 25, 2025

Uh oh!

stdlib-bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

anandkaranubc commented Feb 26, 2025

Uh oh!

anandkaranubc commented Feb 26, 2025 •

edited

Loading

Uh oh!

anandkaranubc commented Feb 26, 2025

Uh oh!

anandkaranubc Feb 26, 2025

Uh oh!

anandkaranubc Feb 26, 2025

Uh oh!

anandkaranubc Feb 26, 2025

Uh oh!

abhishekblue commented Feb 28, 2025

Uh oh!

kgryte Feb 28, 2025

Uh oh!

abhishekblue Mar 3, 2025

Uh oh!

kgryte Feb 28, 2025

Uh oh!

kgryte Feb 28, 2025

Uh oh!

abhishekblue Mar 1, 2025

Uh oh!

kgryte Feb 28, 2025

Uh oh!

Uh oh!

Uh oh!

feat: add assert/has-same-constructor #5446

Are you sure you want to change the base?

feat: add assert/has-same-constructor #5446

Uh oh!

Conversation

abhishekblue commented Feb 25, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc commented Feb 26, 2025

Uh oh!

anandkaranubc commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anandkaranubc commented Feb 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhishekblue commented Feb 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: add `assert/has-same-constructor` #5446

feat: add `assert/has-same-constructor` #5446

stdlib-bot commented Feb 25, 2025 •

edited

Loading

anandkaranubc commented Feb 26, 2025 •

edited

Loading