Skip to content

bench: refactor benchmarks and update test messages in math/base/special/acos #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/array/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var acos = require( './../lib' );
Expand All @@ -34,10 +34,11 @@ bench( pkg, function benchmark( b ) {
var y;
var i;

x = uniform( 100, -1.0, 1.0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*2.0 ) - 1.0;
y = acos( x );
y = acos( x[ i % x.length ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -55,10 +56,11 @@ bench( pkg+'::built-in', function benchmark( b ) {
var y;
var i;

x = uniform( 100, -1.0, 1.0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*2.0 ) - 1.0;
y = Math.acos( x ); // eslint-disable-line stdlib/no-builtin-math
y = Math.acos( x[ i % x.length ] ); // eslint-disable-line stdlib/no-builtin-math
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/array/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var tryRequire = require( '@stdlib/utils/try-require' );
var pkg = require( './../package.json' ).name;
Expand All @@ -43,10 +43,11 @@ bench( pkg+'::native', opts, function benchmark( b ) {
var y;
var i;

x = uniform( 100, -1.0, 1.0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*2.0 ) - 1.0;
y = acos( x );
y = acos( x[ i % x.length ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,19 @@ static double rand_double( void ) {
* @return elapsed time in seconds
*/
static double benchmark( void ) {
double x[ 100 ];
double elapsed;
double x;
double y;
double t;
int i;

for ( i = 0; i < 100; i++ ) {
x[ i ] = ( 2.0*rand_double() ) - 1.0;
}

t = tic();
for ( i = 0; i < ITERATIONS; i++ ) {
x = ( 2.0*rand_double() ) - 1.0;
y = acos( x );
y = acos( x[ i % 100 ] );
if ( y != y ) {
printf( "should not return NaN\n" );
break;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,16 +94,19 @@ static double rand_double( void ) {
* @return elapsed time in seconds
*/
static double benchmark( void ) {
double x[ 100 ];
double elapsed;
double x;
double y;
double t;
int i;

for ( i = 0; i < 100; i++ ) {
x[ i ] = ( 2.0*rand_double() ) - 1.0;
}

t = tic();
for ( i = 0; i < ITERATIONS; i++ ) {
x = ( 2.0*rand_double() ) - 1.0;
y = acos( x );
y = acos( x[ i % 100 ] );
if ( y != y ) {
printf( "should not return NaN\n" );
break;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,19 @@ static double rand_double( void ) {
* @return elapsed time in seconds
*/
static double benchmark( void ) {
double x[ 100 ];
double elapsed;
double x;
double y;
double t;
int i;

for ( i = 0; i < 100; i++ ) {
x[ i ] = ( 2.0*rand_double() ) - 1.0;
}

t = tic();
for ( i = 0; i < ITERATIONS; i++ ) {
x = ( 2.0*rand_double() ) - 1.0;
y = stdlib_base_acos( x );
y = stdlib_base_acos( x[ i % 100 ] );
if ( y != y ) {
printf( "should not return NaN\n" );
break;
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/math/base/special/acos/test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ tape( 'the function computes the arccosine (small positive numbers)', function t

tape( 'the function returns `NaN` if provided a `NaN`', function test( t ) {
var v = acos( NaN );
t.equal( isnan( v ), true, 'returns NaN' );
t.equal( isnan( v ), true, 'returns expected value' );
t.end();
});

Expand All @@ -126,7 +126,7 @@ tape( 'the function returns `NaN` if provided a value less than `-1`', function
var i;
for ( i = 0; i < 1e4; i++ ) {
v = -(randu()*1.0e6) - (1.0+EPS);
t.equal( isnan( acos( v ) ), true, 'returns NaN when provided '+v );
t.equal( isnan( acos( v ) ), true, 'returns expected value when provided '+v );
}
t.end();
});
Expand All @@ -136,7 +136,7 @@ tape( 'the function returns `NaN` if provided a value greater than `+1`', functi
var i;
for ( i = 0; i < 1e4; i++ ) {
v = (randu()*1.0e6) + 1.0 + EPS;
t.equal( isnan( acos( v ) ), true, 'returns NaN when provided '+v );
t.equal( isnan( acos( v ) ), true, 'returns expected value when provided '+v );
}
t.end();
});
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ tape( 'the function computes the arccosine (small positive numbers)', opts, func

tape( 'the function returns `NaN` if provided a `NaN`', opts, function test( t ) {
var v = acos( NaN );
t.equal( isnan( v ), true, 'returns NaN' );
t.equal( isnan( v ), true, 'returns expected value' );
t.end();
});

Expand All @@ -135,7 +135,7 @@ tape( 'the function returns `NaN` if provided a value less than `-1`', opts, fun
var i;
for ( i = 0; i < 1e4; i++ ) {
v = -(randu()*1.0e6) - (1.0+EPS);
t.equal( isnan( acos( v ) ), true, 'returns NaN when provided '+v );
t.equal( isnan( acos( v ) ), true, 'returns expected value when provided '+v );
}
t.end();
});
Expand All @@ -145,7 +145,7 @@ tape( 'the function returns `NaN` if provided a value greater than `+1`', opts,
var i;
for ( i = 0; i < 1e4; i++ ) {
v = (randu()*1.0e6) + 1.0 + EPS;
t.equal( isnan( acos( v ) ), true, 'returns NaN when provided '+v );
t.equal( isnan( acos( v ) ), true, 'returns expected value when provided '+v );
}
t.end();
});