Skip to content

chore: addresses commit comments #5264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

chore: addresses commit comments #5264

merged 1 commit into from
Feb 17, 2025

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves #5232.

Description

What is the purpose of this pull request?

This pull request:

  • Addresses commit comments

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@saurabhraghuvanshii
chore: addresses commit comments
719c3df 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 17, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/cauchy/pdf $\color{green}293/293$
$\color{green}+100.00\%$ 		$\color{green}19/19$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}293/293$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter
Planeshifter approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks for also cleaning up the tests!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 17, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 17, 2025
@saurabhraghuvanshii
Copy link
Contributor Author

welcome sir

@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: addresses commit comments

PR-URL: https://github.com/stdlib-js/stdlib/pull/5264
Closes: https://github.com/stdlib-js/stdlib/issues/5232

Co-authored-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 427d616 into stdlib-js:develop Feb 17, 2025
58 checks passed
@saurabhraghuvanshii saurabhraghuvanshii deleted the cauchy-pdf branch February 18, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit eaecb57)
3 participants
@saurabhraghuvanshii @stdlib-bot @Planeshifter