Skip to content

chore: address commit comments regarding typo and refactor #5263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

suhaib-ilahi
Copy link
Contributor

@suhaib-ilahi suhaib-ilahi commented Feb 17, 2025

Resolves #5237

Description

What is the purpose of this pull request?

This pull request: address the commit comments of (commit 8357863)

Related Issues

Does this pull request have any related issues?
none

This pull request:

Questions

Any questions for reviewers of this pull request?
Hi, reviewers! Could you please check if I have followed the contributing guidelines properly? If there are any mistakes or areas for improvement in my code or approach, I would appreciate your feedback. I'm open to suggestions for making it better!

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Feb 17, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 17, 2025

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ssort2ins $\color{green}521/521$
$\color{green}+100.00\%$
$\color{green}41/41$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}521/521$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@suhaib-ilahi suhaib-ilahi marked this pull request as ready for review February 17, 2025 13:45
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 17, 2025
@suhaib-ilahi suhaib-ilahi marked this pull request as draft February 17, 2025 14:06
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 17, 2025
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 17, 2025
@suhaib-ilahi suhaib-ilahi marked this pull request as ready for review February 17, 2025 14:13
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suhaib-ilahi for your first PR!

Addresses all commit comments and looks fine mostly. I added missing spaces to ensure that we have a space between parameters in function signatures.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 17, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 17, 2025
@Planeshifter Planeshifter changed the title Fixes #5237: Address comments in commit regarding typo and refactor chore: address comments in commit regarding typo and refactor Feb 17, 2025
@Planeshifter Planeshifter changed the title chore: address comments in commit regarding typo and refactor chore: address commit comments regarding typo and refactor Feb 17, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: address commit comments regarding typo and refactor

PR-URL: https://github.com/stdlib-js/stdlib/pull/5263
Closes: https://github.com/stdlib-js/stdlib/issues/5237

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Suhaib <suhaib.elahi87@gmail.com>
Co-authored-by: Suhaib Ilahi <suhaib.elahi87@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 3587230 into stdlib-js:develop Feb 17, 2025
29 of 30 checks passed
@suhaib-ilahi suhaib-ilahi deleted the fix/#5237 branch February 17, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 8357863)
3 participants